From e2c8235a2c3b848cd9ebec42eb23bf40fb07236d Mon Sep 17 00:00:00 2001 From: Allan Shortlidge Date: Mon, 15 Sep 2025 13:56:24 -0700 Subject: [PATCH] Frontend: Temporarily downgrade 'error_module_interface_requires_language_mode'. Downgrade the new error in https://github.com/swiftlang/swift/pull/84244 to a warning. The PR smoke test build is using a different build system that is failing to pass `-swift-version` arguments when building various stdlib modules. That needs to be fixed, but for now we also need to unblock CI. --- lib/Frontend/CompilerInvocation.cpp | 6 ++++-- test/ModuleInterface/language_mode.swift | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/Frontend/CompilerInvocation.cpp b/lib/Frontend/CompilerInvocation.cpp index 79534a755b6ab..2f8b9df386dcc 100644 --- a/lib/Frontend/CompilerInvocation.cpp +++ b/lib/Frontend/CompilerInvocation.cpp @@ -1035,8 +1035,10 @@ static bool ParseLangArgs(LangOptions &Opts, ArgList &Args, if (!isValid) diagnoseSwiftVersion(vers, A, Args, Diags); } else if (FrontendOpts.InputsAndOutputs.hasModuleInterfaceOutputPath()) { - Diags.diagnose({}, diag::error_module_interface_requires_language_mode); - HadError = true; + Diags.diagnose({}, diag::error_module_interface_requires_language_mode) + .limitBehavior(DiagnosticBehavior::Warning); + // FIXME: Make this an error again (rdar://145168219) + // HadError = true; } if (auto A = Args.getLastArg(OPT_package_description_version)) { diff --git a/test/ModuleInterface/language_mode.swift b/test/ModuleInterface/language_mode.swift index d46e32b1eeb89..4522c5fdd38ed 100644 --- a/test/ModuleInterface/language_mode.swift +++ b/test/ModuleInterface/language_mode.swift @@ -1,11 +1,11 @@ // RUN: %empty-directory(%t) -// RUN: not %swift_frontend_plain -target %target-swift-5.1-abi-triple %s \ +// RUN: %swift_frontend_plain -target %target-swift-5.1-abi-triple %s \ // RUN: -enable-library-evolution -module-name Test \ // RUN: -emit-module-interface-path %t.swiftinterface \ // RUN: -emit-module -o /dev/null 2>&1 | %FileCheck %s -// CHECK: :0: error: emitting module interface files requires '-language-mode' +// CHECK: :0: warning: emitting module interface files requires '-language-mode' // RUN: %swift_frontend_plain -target %target-swift-5.1-abi-triple %s \ // RUN: -enable-library-evolution -module-name Test \