Fix a slightly non-deterministic behavior in the Monoids benchmark #84401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please smoke test |
jamieQ
reviewed
Sep 19, 2025
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| // Otherwise, retire this startegy. | |
| // Otherwise, retire this strategy. |
When built with output enabled, sometimes a few lines would be interchanged, depending on the order in which parallel tasks complete. Simplify the dispatcher logic a bit to ensure we get the same output ordering every time. This does not impact the running time of the benchmark.
slavapestov
force-pushed
the
one-more-monoid-benchmark-fix
branch
from
5580cce to
575c709
Compare
Contributor
Author
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When built with output enabled, sometimes a few lines would be interchanged, depending on the order in which parallel tasks complete. Simplify the dispatcher logic a bit to ensure we get the same output ordering every time.
This does not impact the running time of the benchmark.