[cxx-interop] Fix inherited nested types #84455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-hui
requested review from
Xazax-hun,
beccadax,
egorzhdan,
fahadnayyar,
hnrklssn,
ian-twilightcoder,
susmonteiro and
zoecarver
as code owners
Contributor
Author
|
@swift-ci please test |
hnrklssn
reviewed
Sep 23, 2025
test/Interop/Cxx/class/inheritance/nested-types-typechecker.swift
Outdated
Show resolved
Hide resolved
j-hui
force-pushed
the
fix-inherited-nested-types
branch
from
5929f58 to
13529fe
Compare
Contributor
Author
|
@swift-ci please test |
egorzhdan
approved these changes
Sep 23, 2025
Xazax-hun
approved these changes
Sep 23, 2025
When a derived class inherits a nested type from a base class in C++, we expect that derived type member to be the same as the base nested type. This patch fixes the ClangImporter's base member cloning to make that the case, and also fixes up some test cases (renames "sub-type" to "nested type" because the term "subtype" is overloaded and misleading here). rdar://161137420
j-hui
force-pushed
the
fix-inherited-nested-types
branch
from
13529fe to
d0f14a6
Compare
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a derived class inherits a nested type from a base class in C++, we expect that derived type member to be the same as the base nested type. This patch fixes the ClangImporter's base member cloning to make that the case, and also fixes up some test cases (renames "sub-type" to "nested type" because the term "subtype" is overloaded and misleading here).
rdar://161137420