-
Notifications
You must be signed in to change notification settings - Fork 10.6k
CMake: Glibc Overlay #84737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
etcwilde
merged 3 commits into
swiftlang:main
from
etcwilde:ewilde/runtimes-linux-glibc-overlay
Oct 21, 2025
Merged
CMake: Glibc Overlay #84737
etcwilde
merged 3 commits into
swiftlang:main
from
etcwilde:ewilde/runtimes-linux-glibc-overlay
Oct 21, 2025
+141
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Platform availability is an Apple concept because Swift is shipped as part of the OS. It doesn't make sense to check or to warn on other platforms. Only checking and setting it for Apple platforms.
Member
Author
|
@swift-ci please smoke test |
compnerd
approved these changes
Oct 7, 2025
ca572b0 to
5369578
Compare
Member
Author
|
@swift-ci please smoke test |
Explicit module builds crash the compiler when building the glibc overlay library. The crash occurs in the Swift driver dependency scanner. It appears to be related to vfs overlays, modulemaps, injected header files, and explicit module builds. This is odd though because the Android builds also have this combination, but work.
5369578 to
59ade4c
Compare
Member
Author
|
@swift-ci please smoke test |
edymtt
reviewed
Oct 7, 2025
Member
Author
|
@swift-ci please smoke test Linux Platform |
Adding a new glibc overlay for Linux builds. We will eventually need one for Musl, and if someone really wants to, LLVM and cosmopolitan libcs are also out there.
59ade4c to
44830d7
Compare
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
@swift-ci please test Windows platform |
Member
Author
|
@swift-ci please test Windows platform |
edymtt
approved these changes
Oct 20, 2025
Member
Author
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a Glibc overlay for Linux. As part of this, I bumped the stdlib version override to only apply to Apple platforms since that's the only place where those have meaning. This way we don't see warnings about not recognizing the other platforms.