Skip to content

Run closure specialization only if ownership info is present in callee #84956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2025
Merged

Run closure specialization only if ownership info is present in callee #84956

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86b599b
[AutoDiff] Run closure spec only if ownership info is present in pull…
kovdan01 Oct 16, 2025
93169c1
Address review comments
kovdan01 Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions SwiftCompilerSources/Sources/Optimizer/FunctionPasses/ClosureSpecialization.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,13 @@ private func isCalleeSpecializable(of apply: ApplySite) -> Bool {
if let callee = apply.referencedFunction,
callee.isDefinition,

// Calling `cloneRecursively` from `SpecializationInfo.cloneClosures`
// requires the callee having ownership info. Otherwise, the cloner
// uses `recordFoldedValue` instead of `recordClonedInstruction`, and
// `postProcess` hook is not called, which leads to an assertion
// failure in `BridgedClonerImpl::cloneInst`.
callee.hasOwnership,

// We don't support generic functions (yet)
!apply.hasSubstitutions,

Expand Down