Skip to content

[cxx-interop] Do not treat SWIFT_RETURNS_INDEPENDENT_VALUE unsafe #84980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

[cxx-interop] Do not treat SWIFT_RETURNS_INDEPENDENT_VALUE unsafe #84980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ClangImporter/ClangImporter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8782,7 +8782,7 @@ ClangDeclExplicitSafety::evaluate(Evaluator &evaluator,

// Explicitly unsafe.
auto decl = desc.decl;
if (hasUnsafeAPIAttr(decl) || hasSwiftAttribute(decl, "unsafe"))
if (hasSwiftAttribute(decl, "unsafe"))
return ExplicitSafety::Unsafe;

// Explicitly safe.
Expand Down
9 changes: 8 additions & 1 deletion test/Interop/Cxx/class/safe-interop-mode.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,12 @@ using TTakePtr = TTake<int *>;
using TTakeSafeTuple = TTake<SafeTuple>;
using TTakeUnsafeTuple = TTake<UnsafeTuple>;

struct HoldsShared {
SharedObject* obj;

SharedObject* getObj() const SWIFT_RETURNS_INDEPENDENT_VALUE;
};

//--- test.swift

import Test
Expand Down Expand Up @@ -183,8 +189,9 @@ func useSharedReference(frt: SharedObject, x: OwnedData) {
}

@available(SwiftStdlib 5.8, *)
func useSharedReference(frt: DerivedFromSharedObject) {
func useSharedReference(frt: DerivedFromSharedObject, h: HoldsShared) {
let _ = frt
let _ = h.getObj()
}

func useTTakeInt(x: TTakeInt) {
Expand Down