From 7bb97a581d996217e8d32ee03d3890d0757fd35c Mon Sep 17 00:00:00 2001 From: Jamie <2119834+jamieQ@users.noreply.github.com> Date: Tue, 21 Oct 2025 08:32:14 -0500 Subject: [PATCH] [NFC][SILOptimizer]: remove seemingly unused StripDebugInfo pass --- .../swift/SILOptimizer/PassManager/Passes.def | 2 - lib/SILOptimizer/UtilityPasses/CMakeLists.txt | 1 - .../UtilityPasses/StripDebugInfo.cpp | 51 ------------------- test/SILOptimizer/strip_debug_info.sil | 18 ------- utils/pass-pipeline/src/passes.py | 2 - 5 files changed, 74 deletions(-) delete mode 100644 lib/SILOptimizer/UtilityPasses/StripDebugInfo.cpp delete mode 100644 test/SILOptimizer/strip_debug_info.sil diff --git a/include/swift/SILOptimizer/PassManager/Passes.def b/include/swift/SILOptimizer/PassManager/Passes.def index 062a3f1b9dc5d..0f20c7781bdeb 100644 --- a/include/swift/SILOptimizer/PassManager/Passes.def +++ b/include/swift/SILOptimizer/PassManager/Passes.def @@ -434,8 +434,6 @@ LEGACY_PASS(SplitAllCriticalEdges, "split-critical-edges", "Split all Critical Edges in the SIL CFG") LEGACY_PASS(SplitNonCondBrCriticalEdges, "split-non-cond_br-critical-edges", "Split all Critical Edges not from SIL cond_br") -LEGACY_PASS(StripDebugInfo, "strip-debug-info", - "Strip Debug Information") LEGACY_PASS(StringOptimization, "string-optimization", "Optimization for String operations") LEGACY_PASS(SwiftArrayPropertyOpt, "array-property-opt", diff --git a/lib/SILOptimizer/UtilityPasses/CMakeLists.txt b/lib/SILOptimizer/UtilityPasses/CMakeLists.txt index a59dc8e9cfe04..5f1940df9310a 100644 --- a/lib/SILOptimizer/UtilityPasses/CMakeLists.txt +++ b/lib/SILOptimizer/UtilityPasses/CMakeLists.txt @@ -27,7 +27,6 @@ target_sources(swiftSILOptimizer PRIVATE SILDebugInfoGenerator.cpp SILSkippingChecker.cpp SimplifyUnreachableContainingBlocks.cpp - StripDebugInfo.cpp TestRunner.cpp OwnershipDumper.cpp OwnershipVerifierTextualErrorDumper.cpp) diff --git a/lib/SILOptimizer/UtilityPasses/StripDebugInfo.cpp b/lib/SILOptimizer/UtilityPasses/StripDebugInfo.cpp deleted file mode 100644 index b5ee98e2c8713..0000000000000 --- a/lib/SILOptimizer/UtilityPasses/StripDebugInfo.cpp +++ /dev/null @@ -1,51 +0,0 @@ -//===--- StripDebugInfo.cpp - Strip debug info from SIL -------------------===// -// -// This source file is part of the Swift.org open source project -// -// Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors -// Licensed under Apache License v2.0 with Runtime Library Exception -// -// See https://swift.org/LICENSE.txt for license information -// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors -// -//===----------------------------------------------------------------------===// - -#include "swift/SILOptimizer/PassManager/Passes.h" -#include "swift/SILOptimizer/PassManager/Transforms.h" -#include "swift/SIL/SILInstruction.h" -#include "swift/SIL/SILModule.h" -#include "swift/SIL/SILFunction.h" - - -using namespace swift; - -static void stripFunction(SILFunction *F) { - for (auto &BB : *F) - for (auto II = BB.begin(), IE = BB.end(); II != IE;) { - SILInstruction *Inst = &*II; - ++II; - - if (!isa(Inst)) - continue; - - Inst->eraseFromParent(); - } -} - -namespace { -class StripDebugInfo : public swift::SILFunctionTransform { - ~StripDebugInfo() override {} - - /// The entry point to the transformation. - void run() override { - stripFunction(getFunction()); - invalidateAnalysis(SILAnalysis::InvalidationKind::Instructions); - } - -}; -} // end anonymous namespace - - -SILTransform *swift::createStripDebugInfo() { - return new StripDebugInfo(); -} diff --git a/test/SILOptimizer/strip_debug_info.sil b/test/SILOptimizer/strip_debug_info.sil deleted file mode 100644 index 22371c1a8e6f7..0000000000000 --- a/test/SILOptimizer/strip_debug_info.sil +++ /dev/null @@ -1,18 +0,0 @@ -// RUN: %target-sil-opt -enable-sil-verify-all -strip-debug-info %s | %FileCheck %s - -sil_stage canonical - -import Swift -import Builtin - -// CHECK-LABEL: sil @test -// CHECK: bb0 -// CHECK-NEXT: tuple -// CHECK-NEXT: return -sil @test : $@convention(thin) (@inout T, Builtin.Int64) -> () { -bb0(%0 : $*T, %1 : $Builtin.Int64): - debug_value %0 : $*T, expr op_deref - debug_value %1 : $Builtin.Int64 - %2 = tuple () - return %2 : $() -} diff --git a/utils/pass-pipeline/src/passes.py b/utils/pass-pipeline/src/passes.py index c5e5afd34e150..51ffc3a90b84a 100644 --- a/utils/pass-pipeline/src/passes.py +++ b/utils/pass-pipeline/src/passes.py @@ -48,7 +48,6 @@ SpeculativeDevirtualizer = Pass('SpeculativeDevirtualizer') SplitAllCriticalEdges = Pass('SplitAllCriticalEdges') SplitNonCondBrCriticalEdges = Pass('SplitNonCondBrCriticalEdges') -StripDebugInfo = Pass('StripDebugInfo') SwiftArrayOpts = Pass('SwiftArrayOpts') PASSES = [ @@ -97,6 +96,5 @@ SpeculativeDevirtualizer, SplitAllCriticalEdges, SplitNonCondBrCriticalEdges, - StripDebugInfo, SwiftArrayOpts, ]