TaskQueue(Test): Add destructor to close FDs, preventing resource leak, fix race in TaskSignalHandling test #85083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `sleep` with `condition_variable` synchronization to ensure the child PID is captured before attempting to kill it. This eliminates timing dependencies.
The `Task` class was missing a destructor to close pipe file descriptors when destroyed. This caused file descriptor exhaustion after ~2,187 test runs, making tests fail with POLLNVAL errors when the system ran out of resources. This was found with: ``` ./unittests/Basic/SwiftBasicTests --gtest_filter="TaskQueueTest.*" --gtest_repeat=1000 ```
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@swift-ci Please test macOS platform |
artemcm
approved these changes
Oct 23, 2025
Contributor
|
@swift-ci please test Windows platform |
glessard
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TaskQueue: Add destructor to close FDs, preventing resource leakThe
Taskclass was missing a destructor to close pipe file descriptors when destroyed. This caused file descriptor exhaustion after ~2,187 test runs, making tests fail withPOLLNVALerrors when the system ran out of resources.This was found with:
TaskQueueTest: Fix race condition inTaskSignalHandlingtestReplace
sleepwithcondition_variablesynchronization to ensure the child PID is captured before attempting to kill it. This eliminates timing dependencies.