Skip to content

Fix various warnings #85132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2025
+18 −17
Merged

Fix various warnings #85132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
539b49b
Concurrency: Suppress -Wnontrivial-memcall warning in Actor.cpp.
tshortli Oct 25, 2025
0c7d872
stdlib: Remove an unnecessary 'unsafe' expression in StringBridge.swift.
tshortli Oct 25, 2025
d6c9080
ASTGen: Suppress spurious retroactive conformance warnings.
tshortli Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions lib/ASTGen/Sources/ASTGen/Bridge.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,21 +31,21 @@ extension BridgedNullable {
}
}

extension SourceLoc: /*@retroactive*/ swiftASTGen.BridgedNullable {}
extension Identifier: /*@retroactive*/ swiftASTGen.BridgedNullable {}
extension BridgedNullableDecl: /*@retroactive*/ swiftASTGen.BridgedNullable {}
extension BridgedNullableExpr: /*@retroactive*/ swiftASTGen.BridgedNullable {}
extension BridgedNullableStmt: /*@retroactive*/ swiftASTGen.BridgedNullable {}
extension BridgedNullableTypeRepr: /*@retroactive*/ swiftASTGen.BridgedNullable {}
extension BridgedNullablePattern: /*@retroactive*/ swiftASTGen.BridgedNullable {}
extension BridgedNullableGenericParamList: /*@retroactive*/ swiftASTGen.BridgedNullable {}
extension BridgedNullableTrailingWhereClause: /*@retroactive*/ swiftASTGen.BridgedNullable {}
extension BridgedNullableParameterList: /*@retroactive*/ swiftASTGen.BridgedNullable {}
extension BridgedNullablePatternBindingInitializer: /*@retroactive*/ swiftASTGen.BridgedNullable {}
extension BridgedNullableDefaultArgumentInitializer: /*@retroactive*/ swiftASTGen.BridgedNullable {}
extension BridgedNullableCustomAttributeInitializer: /*@retroactive*/ swiftASTGen.BridgedNullable {}
extension BridgedNullableArgumentList: /*@retroactive*/ swiftASTGen.BridgedNullable {}
extension BridgedNullableVarDecl: /*@retroactive*/ swiftASTGen.BridgedNullable {}
extension SourceLoc: /*@retroactive*/ swiftASTGen.BridgedNullable, Swift.ExpressibleByNilLiteral {}
extension Identifier: /*@retroactive*/ swiftASTGen.BridgedNullable, Swift.ExpressibleByNilLiteral {}
extension BridgedNullableDecl: /*@retroactive*/ swiftASTGen.BridgedNullable, Swift.ExpressibleByNilLiteral {}
extension BridgedNullableExpr: /*@retroactive*/ swiftASTGen.BridgedNullable, Swift.ExpressibleByNilLiteral {}
extension BridgedNullableStmt: /*@retroactive*/ swiftASTGen.BridgedNullable, Swift.ExpressibleByNilLiteral {}
extension BridgedNullableTypeRepr: /*@retroactive*/ swiftASTGen.BridgedNullable, Swift.ExpressibleByNilLiteral {}
extension BridgedNullablePattern: /*@retroactive*/ swiftASTGen.BridgedNullable, Swift.ExpressibleByNilLiteral {}
extension BridgedNullableGenericParamList: /*@retroactive*/ swiftASTGen.BridgedNullable, Swift.ExpressibleByNilLiteral {}
extension BridgedNullableTrailingWhereClause: /*@retroactive*/ swiftASTGen.BridgedNullable, Swift.ExpressibleByNilLiteral {}
extension BridgedNullableParameterList: /*@retroactive*/ swiftASTGen.BridgedNullable, Swift.ExpressibleByNilLiteral {}
extension BridgedNullablePatternBindingInitializer: /*@retroactive*/ swiftASTGen.BridgedNullable, Swift.ExpressibleByNilLiteral {}
extension BridgedNullableDefaultArgumentInitializer: /*@retroactive*/ swiftASTGen.BridgedNullable, Swift.ExpressibleByNilLiteral {}
extension BridgedNullableCustomAttributeInitializer: /*@retroactive*/ swiftASTGen.BridgedNullable, Swift.ExpressibleByNilLiteral {}
extension BridgedNullableArgumentList: /*@retroactive*/ swiftASTGen.BridgedNullable, Swift.ExpressibleByNilLiteral {}
extension BridgedNullableVarDecl: /*@retroactive*/ swiftASTGen.BridgedNullable, Swift.ExpressibleByNilLiteral {}

extension Identifier: /*@retroactive*/ Swift.Equatable {
public static func == (lhs: Self, rhs: Self) -> Bool {
Expand Down
3 changes: 2 additions & 1 deletion stdlib/public/Concurrency/Actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2774,7 +2774,8 @@ swift::swift_distributedActor_remote_initialize(const Metadata *actorType) {

// TODO: remove this memset eventually, today we only do this to not have
// to modify the destructor logic, as releasing zeroes is no-op
memset(alloc + 1, 0, metadata->getInstanceSize() - sizeof(HeapObject));
memset((void *)(alloc + 1), 0,
metadata->getInstanceSize() - sizeof(HeapObject));

// TODO(distributed): a remote one does not have to have the "real"
// default actor body, e.g. we don't need an executor at all; so
Expand Down
2 changes: 1 addition & 1 deletion stdlib/public/core/StringBridge.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,7 @@ extension String {
_connectOrphanedFoundationSubclassesIfNeeded()

if _guts.isSmall {
return unsafe _guts.asSmall.withUTF8 { bufPtr in
return _guts.asSmall.withUTF8 { bufPtr in
// Smol ASCII a) may bridge to tagged pointers, b) can't contain a BOM
if _guts.isSmallASCII, let result = unsafe _createCFString(
bufPtr.baseAddress._unsafelyUnwrappedUnchecked,
Expand Down