Skip to content

SIL: Fix a -Wimplicit-fallthrough warning #85156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2025
Merged

SIL: Fix a -Wimplicit-fallthrough warning #85156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/SIL/Verifier/SILVerifier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2550,7 +2550,8 @@ class SILVerifier : public SILVerifierBase<SILVerifier> {
case BuiltinValueKind::id: \
require(false, \
"this builtin should never show up as builtin inst. It should " \
"only result in other SIL instructions being emitted by SILGen");
"only result in other SIL instructions being emitted by SILGen"); \
break;
#define BUILTIN(ID, Name, Attrs) \
case BuiltinValueKind::ID: \
break;
Expand Down
2 changes: 1 addition & 1 deletion utils/build-presets.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,7 +681,7 @@ enable-new-runtime-build

# Escalate certain C++ warnings to errors for Swift.
extra-swift-cmake-options=
-DSWIFT_EXTRA_CXX_FLAGS="-Werror=unused -Werror=uninitialized"
-DSWIFT_EXTRA_CXX_FLAGS="-Werror=unused -Werror=uninitialized -Werror=implicit-fallthrough"

[preset: buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx,flto]
mixin-preset=buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx
Expand Down