[CS] Upgrade a couple of tuple warnings to error for future lang mode #85188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
hborla,
slavapestov and
xedin
as code owners
I missed upgrading this to an error for Swift 6 mode, let's upgrade it to an error for a future language mode. It's important we reject these cases since we're otherwise allowing subtyping to be a weaker constraint than conversion.
"reorder" seems a bit less jargony than "shuffle", and include the labels that are being reordered.
This has been deprecated for a while now, flip it to an error for a future language mode.
hamishknight
force-pushed
the
tuple-trouble
branch
from
7364108 to
00d8774
Compare
hamishknight
requested review from
CodaFi,
DougGregor,
bnbarham and
rintaro
as code owners
hamishknight
changed the title
Contributor
Author
|
@swift-ci please test |
slavapestov
approved these changes
Oct 29, 2025
Contributor
|
@swift-ci Please test source compatibility |
Contributor
|
(Just in case :) ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed upgrading the tuple label mismatch warning to an error for Swift 6 mode, let's upgrade it to an error for a future language mode. It's important we reject these cases since we're otherwise allowing subtyping to be a weaker constraint than conversion. While here let's do the same for tuple shuffles, I also took the opportunity to improve the wording of the diagnostic a bit.