Pass SDK paths explicitly when building Runtimes in macOS smoketest #85206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per https://gitlab.kitware.com/cmake/cmake/-/commit/7b195312919cbf69497af2514b91b55bd9a6da71 CMake 4.0 does not pass `-sdk` to compiler invocations if the user does not provide `CMAKE_OSX_SYSROOT` -- this in turn causes failures in linking. Addresses rdar://163672815
edymtt
requested review from
compnerd,
etcwilde and
justice-adams-apple
as code owners
Contributor
Author
|
@swift-ci please smoke test |
compnerd
approved these changes
Oct 29, 2025
Contributor
Author
|
@swift-ci please smoke test Windows |
Contributor
Author
|
@swift-ci please smoke test Windows |
edymtt
deleted the
edymtt/explicitly-set-cmake-osx-sysroot-in-macos-smoketest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://gitlab.kitware.com/cmake/cmake/-/commit/7b195312919cbf69497af2514b91b55bd9a6da71 CMake 4.0 does not pass
-sdkto compiler invocations if the user does not provideCMAKE_OSX_SYSROOT-- this in turn causes failures in linking.Addresses rdar://163672815