[Serialization] Allow near-misses when matching imported Clang declarations #85262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
requested review from
Xazax-hun,
beccadax,
eeckstein,
egorzhdan,
fahadnayyar,
hborla,
hnrklssn,
ian-twilightcoder,
j-hui,
jckarter,
ktoso,
rjmccall,
slavapestov,
susmonteiro,
xedin,
xymus and
zoecarver
as code owners
Member
Author
|
This PR is stacked on #85203, and only the latest commit is new. |
Member
Author
|
@swift-ci please smoke test |
1 similar comment
Member
Author
|
@swift-ci please smoke test |
…ations Fixes the rest of rdar://137014448.
…tching clang declarations
DougGregor
force-pushed
the
clang-deserialization-near-miss
branch
from
e892bfc to
1bae4da
Compare
Member
Author
|
Force-pushed now that the other PR merged |
Member
Author
|
@swift-ci please test |
Member
Author
|
@swift-ci please test Windows |
Member
Author
|
@swift-ci please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deserializing an underlying Clang-imported declaration, ignore small differences in the type matching where it doesn't affect the type in C itself, such as nullability or sendability. This prevents these minor differences from causing SIL deserialization failures where they don't have to.
Fixes the rest of rdar://137014448.