Skip to content

[AST] Fix UB appearing due to strict aliasing rule violation #85286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

[AST] Fix UB appearing due to strict aliasing rule violation #85286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions include/swift/AST/DeclNameLoc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,11 @@ class DeclNameLoc {
/// Retrieve a pointer to either the only source location that was
/// stored or to the array of source locations that was stored.
SourceLoc const * getSourceLocs() const {
if (NumArgumentLabels == 0 && !HasModuleSelectorLoc)
if (NumArgumentLabels == 0 && !HasModuleSelectorLoc) {
if (LocationInfo == nullptr)
return nullptr;
return reinterpret_cast<SourceLoc const *>(&LocationInfo);
}

return reinterpret_cast<SourceLoc const *>(LocationInfo);
}
Expand Down Expand Up @@ -110,7 +113,10 @@ class DeclNameLoc {

/// Retrieve the location of the base name.
SourceLoc getBaseNameLoc() const {
return getSourceLocs()[BaseNameIndex];
const SourceLoc *SourceLocs = getSourceLocs();
if (SourceLocs == nullptr)
return SourceLoc();
return SourceLocs[BaseNameIndex];
}

/// Retrieve the location of the left parentheses.
Expand Down