Skip to content

[update-checkout] fix incorrect number of returned values #85289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
Merged

[update-checkout] fix incorrect number of returned values #85289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions utils/update_checkout/update_checkout/update_checkout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import sys
import traceback
from multiprocessing import freeze_support
from typing import Any, Dict, Hashable, Optional, Set, List, Union
from typing import Any, Dict, Hashable, Optional, Set, List, Tuple, Union

from .cli_arguments import CliArguments
from .git_command import Git, GitException
Expand Down Expand Up @@ -394,7 +394,7 @@ def update_all_repositories(
scheme_name: str,
scheme_map: Optional[Dict[str, Any]],
cross_repos_pr: Dict[str, str],
):
) -> Tuple[List[SkippedReason], List[Union[Exception, None]]]:
skipped_repositories = []
pool_args: List[UpdateArguments] = []
timestamp = get_timestamp_to_match(args.match_timestamp, args.source_root)
Expand Down Expand Up @@ -439,7 +439,7 @@ def update_all_repositories(

locked_repositories: set[str] = _is_any_repository_locked(pool_args)
if len(locked_repositories) > 0:
return [
return skipped_repositories, [
Exception(f"'{repo_name}' is locked by git. Cannot update it.")
for repo_name in locked_repositories
]
Expand Down