From 7f5dd0cb8f7ee0d93b02bc6b35212730cad4d29c Mon Sep 17 00:00:00 2001 From: Kavon Farvardin Date: Tue, 4 Nov 2025 09:21:26 -0800 Subject: [PATCH] NFC: use -Werror flags in all Darwin tests Running only during smoke tests mean that a PR merged with a full test can introduce build failures. --- utils/build-presets.ini | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/utils/build-presets.ini b/utils/build-presets.ini index d46918cbaa68b..19bc48b1617d0 100644 --- a/utils/build-presets.ini +++ b/utils/build-presets.ini @@ -347,6 +347,11 @@ skip-test-cmark build-embedded-stdlib-cross-compiling +# Escalate certain C++ warnings to errors for Swift. +extra-swift-cmake-options= + -DSWIFT_EXTRA_CXX_FLAGS="-Werror=unused -Werror=uninitialized -Werror=implicit-fallthrough" + + [preset: buildbot_incremental_base_all_platforms] mixin-preset=buildbot_incremental_base @@ -679,10 +684,6 @@ skip-test-llbuild enable-new-runtime-build -# Escalate certain C++ warnings to errors for Swift. -extra-swift-cmake-options= - -DSWIFT_EXTRA_CXX_FLAGS="-Werror=unused -Werror=uninitialized -Werror=implicit-fallthrough" - [preset: buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx,flto] mixin-preset=buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx build-subdir=buildbot_incremental