[utils] mark update-verify-tests tests unsupported with old Python #85388
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This utility uses the walrus operator introduced in Python 3.8, but this causes tests to fail in Amazon Linux 2 CI, which uses Python 3.7. Since this is not a shipped product, that doesn't really matter, and 3.7 is an ancient EOL version anyways. The premerge CI uses Python 3.9 and later, so use that as a basis, just to avoid the same issue in the future in case some Python 3.9 feature sneaks in. rdar://164151931
Member
Author
|
@swift-ci please smoke test |
j-hui
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This utility uses the walrus operator introduced in Python 3.8, but this causes tests to fail in Amazon Linux 2 CI, which uses Python 3.7. Since this is not a shipped product, that doesn't really matter, and 3.7 is an ancient EOL version anyways. The premerge CI uses Python 3.9 and later, so use that as a basis, just to avoid the same issue in the future in case some Python 3.9 feature sneaks in.
rdar://164151931