AST: Rename GenericContext::isGeneric to hasGenericParamList
#85433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
Xazax-hun,
beccadax,
bnbarham,
egorzhdan,
hamishknight,
hborla,
ian-twilightcoder,
j-hui,
jckarter,
kavon,
rintaro,
rjmccall,
slavapestov,
susmonteiro,
tshortli and
xedin
as code owners
Collaborator
Author
|
@swift-ci please smoke test |
hamishknight
approved these changes
Nov 11, 2025
| \item \texttt{getParsedGenericParams()} returns the declaration's parsed generic parameter list, or \texttt{nullptr}. | ||
| \item \texttt{getGenericParams()} returns the declaration's full generic parameter list, which includes any implicit generic parameters. Evaluates a \texttt{GenericParamListRequest}. | ||
| \item \texttt{isGeneric()} answers if this declaration has a generic parameter list. This is equivalent to calling \texttt{DeclContext::isInnermostContextGeneric()}. Compare with \texttt{DeclContext::isGenericContext()}. | ||
| \item \texttt{isGenericParamList()} answers if this declaration has a generic parameter list. This is equivalent to calling \texttt{DeclContext::isInnermostContextGeneric()}. Compare with \texttt{DeclContext::isGenericContext()}. |
Contributor
There was a problem hiding this comment.
Suggested change
| \item \texttt{isGenericParamList()} answers if this declaration has a generic parameter list. This is equivalent to calling \texttt{DeclContext::isInnermostContextGeneric()}. Compare with \texttt{DeclContext::isGenericContext()}. | |
| \item \texttt{hasGenericParamList()} answers if this declaration has a generic parameter list. This is equivalent to calling \texttt{DeclContext::isInnermostContextGeneric()}. Compare with \texttt{DeclContext::isGenericContext()}. |
Contributor
There was a problem hiding this comment.
Unfortunately this leads to an overfull hbox:
Don't worry about updating declarations.tex, I'll fix it myself.
Contributor
There was a problem hiding this comment.
Although changing \texttt{DeclContext::isInnermostContextGeneric()} to \texttt{isInnermostContextGeneric()} on \texttt{DeclContext} seems to work:
`isGeneric` is a misleading name because this method checks for the existence of a `GenericParamList`, which is not implied by genericity.
AnthonyLatsis
force-pushed
the
jepa-main4
branch
from
49cf886 to
bda6edb
Compare
Collaborator
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isGenericis a misleading name because this method checks for the existence of aGenericParamList, which is not implied by genericity.