CMake: Add GlibC Clang Overlay to export set #85778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the Glibc Clang Overlay interface target to the installed export set. The interface library exists to plumb the appropriate flags through the build graph and ensure that the modulemap and header file are generated when depended on. Interface libraries need to be in the export set when depended on by a public library to ensure that the appropriate install interface flags are exposed to targets importing the library from outside of the build system, regardless of whether the interface library actually installs any files. This fixes the configuration-time error: Export called with target "swiftGlibc" which requires "SwiftGlibcClangOverlay" that is not in any export set.
etcwilde
requested review from
compnerd,
edymtt and
justice-adams-apple
as code owners
Member
Author
|
@swift-ci please smoke test |
compnerd
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the Glibc Clang Overlay interface target to the installed export set. The interface library exists to plumb the appropriate flags through the build graph and ensure that the modulemap and header file are generated when depended on.
Interface libraries need to be in the export set when depended on by a public library to ensure that the appropriate install interface flags are exposed to targets importing the library from outside of the build system, regardless of whether the interface library actually installs any files.
This fixes the configuration-time error: