Don't block waiting for debug configurations #1914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a folder is added to the workspace context we were awaiting the `makeDebugConfigurations` method. This method generates launch configurations in the launch.json. If the method finds it needs to update existing launch configurations, it puts of a warning message dialog prompting the user for action. Because we were awaiting this method, the dialog blocks folder addition and in turn prevents sourcekit-lsp and other extension features from activating for the folder until the dialog is dismissed. Because nothing relies on the result of `makeDebugConfigurations`, simply kick off the work but don't await it. Issue: swiftlang#1912
plemarquand
requested review from
0xTim,
adam-fowler and
award999
as code owners
award999
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a folder is added to the workspace context we were awaiting the
makeDebugConfigurationsmethod. This method generates launch configurations in the launch.json. If the method finds it needs to update existing launch configurations, it puts of a warning message dialog prompting the user for action.Because we were awaiting this method, the dialog blocks folder addition and in turn prevents sourcekit-lsp and other extension features from activating for the folder until the dialog is dismissed.
Because nothing relies on the result of
makeDebugConfigurations, simply kick off the work but don't await it.Issue: #1912
Tasks
Required tests have been writtenDocumentation has been updatedAdded an entry to CHANGELOG.md if applicable