Skip to content
Permalink
Branch: master
Commits on Mar 10, 2019
  1. bumped version to 6.2.1-DEV

    fabpot committed Mar 10, 2019
  2. prepared the 6.2.0 release

    fabpot committed Mar 10, 2019
Commits on Feb 27, 2019
  1. minor #1177 added missing space (OskarStark)

    fabpot committed Feb 27, 2019
    This PR was merged into the 6.2-dev branch.
    
    Discussion
    ----------
    
    added missing space
    
    <!-- Please fill in this template according to the PR you're about to submit. -->
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | Doc update?   | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    
    <!-- Replace this comment by the description of your issue. -->
    
    Commits
    -------
    
    bd8223e added missing space
  2. added missing space

    OskarStark committed Feb 27, 2019
Commits on Jan 30, 2019
  1. bug #1170 Make the default of debugHeadersData an array (TysonAndre)

    fabpot committed Jan 30, 2019
    This PR was merged into the 6.2-dev branch.
    
    Discussion
    ----------
    
    Make the default of debugHeadersData an array
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | Doc update?   | ?
    | BC breaks?    | ?
    | Deprecations? | no
    | Fixed tickets |
    | License       | MIT
    
    See https://github.com/php/php-src/blob/PHP-7.1.26/UPGRADING#L81-L82
    
    > The empty index operator (e.g. $str[] = $x) is not supported for strings
    > anymore, and throws a fatal error instead of silently converting to array.
    
    ```
    php > $x = new stdClass();
    php > $x->prop = '';
    php > $x->prop[] = 'value';
    Warning: Uncaught Error: [] operator not supported for strings in php shell code:1
    Stack trace:
    #0 {main}
      thrown in php shell code on line 1
    ```
    
    Detected via static analysis.
    
    **The same issue is also detected in v5.4.12 in private $_debugHeadersData - I'm not sure if v5 aims to support php 7.1**
    
    Commits
    -------
    
    5b6ba9a Make the default of debugHeadersData an array
  2. Make the default of debugHeadersData an array

    TysonAndre committed Jan 30, 2019
    See https://github.com/php/php-src/blob/PHP-7.1.26/UPGRADING#L81-L82
    
    > The empty index operator (e.g. $str[] = $x) is not supported for strings
    > anymore, and throws a fatal error instead of silently converting to array.
    
    ```
    php > $x = new stdClass();
    php > $x->prop = '';
    php > $x->prop[] = 'value';
    Warning: Uncaught Error: [] operator not supported for strings in php shell code:1
    Stack trace:
    #0 {main}
      thrown in php shell code on line 1
    ```
    
    Detected via static analysis
Commits on Jan 20, 2019
  1. minor #1168 fix fromPath return type. See issue #1164 (garak)

    fabpot committed Jan 20, 2019
    This PR was merged into the 6.2-dev branch.
    
    Discussion
    ----------
    
    fix fromPath return type. See issue #1164
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | Doc update?   | no
    | BC breaks?    | no
    | Deprecations? | no
    | Fixed tickets | #1164
    | License       | MIT
    
    Commits
    -------
    
    e1dd436 fix fromPath return type. See issue #1164
  2. fix fromPath return type. See issue #1164

    garak committed Jan 20, 2019
Commits on Jan 19, 2019
  1. minor #1167 Added Symfony polyfill mbstring/iconv as requirements (fa…

    fabpot committed Jan 19, 2019
    …bpot)
    
    This PR was squashed before being merged into the 6.2-dev branch (closes #1167).
    
    Discussion
    ----------
    
    Added Symfony polyfill mbstring/iconv as requirements
    
    <!-- Please fill in this template according to the PR you're about to submit. -->
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | yes
    | Doc update?   | no
    | BC breaks?    | no
    | Deprecations? | no
    | Fixed tickets | n/a
    | License       | MIT
    
    <!-- Replace this comment by the description of your issue. -->
    
    Commits
    -------
    
    13354e9 added iconv as a dependency
    21e7b2a added the Symfony mbstring polyfill as a requirement
  2. added iconv as a dependency

    fabpot committed Jan 19, 2019
  3. added the Symfony mbstring polyfill as a requirement

    fabpot committed Jan 19, 2019
  4. feature #1163 Add support for symfony/polyfill-intl-dn (fabpot)

    fabpot committed Jan 19, 2019
    This PR was merged into the 6.2-dev branch.
    
    Discussion
    ----------
    
    Add support for symfony/polyfill-intl-dn
    
    <!-- Please fill in this template according to the PR you're about to submit. -->
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | Doc update?   | no
    | BC breaks?    | no
    | Deprecations? | no
    | Fixed tickets | n/a
    | License       | MIT
    
    <!-- Replace this comment by the description of your issue. -->
    
    Commits
    -------
    
    ff49aaa added support for symfony/polyfill-intl-dn
Commits on Jan 18, 2019
  1. added support for symfony/polyfill-intl-dn

    fabpot committed Jan 18, 2019
  2. feature #1162 Character stream refactoring (fabpot)

    fabpot committed Jan 18, 2019
    This PR was squashed before being merged into the 6.1-dev branch (closes #1162).
    
    Discussion
    ----------
    
    Character stream refactoring
    
    <!-- Please fill in this template according to the PR you're about to submit. -->
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | Doc update?   | no
    | BC breaks?    | no
    | Deprecations? | yes
    | Fixed tickets | n/a
    | License       | MIT
    
    <!-- Replace this comment by the description of your issue. -->
    
    Commits
    -------
    
    919a814 deprecated Swift_CharacterStream_ArrayCharacterStream and Swift_CharacterStream_NgCharacterStream in favor of Swift_CharacterStream_CharacterStream
    6fb82b9 bumped version to 6.2
Commits on Jan 17, 2019
  1. deprecated Swift_CharacterStream_ArrayCharacterStream and Swift_Chara…

    fabpot committed Jan 17, 2019
    …cterStream_NgCharacterStream in favor of Swift_CharacterStream_CharacterStream
  2. bumped version to 6.2

    fabpot committed Jan 17, 2019
Commits on Jan 11, 2019
  1. bug #1160 Fix exception containing stack trace (enumag)

    fabpot committed Jan 11, 2019
    This PR was merged into the 6.1-dev branch.
    
    Discussion
    ----------
    
    Fix exception containing stack trace
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | Doc update?   | no
    | BC breaks?    | no
    | Deprecations? | no
    | Fixed tickets |
    | License       | MIT
    
    Right now the error message of `TransportException` can contain very long messages including stack traces of other exceptions. For example:
    
    ```
    Failed to authenticate on SMTP server with username "example@domain.tld" using 1 possible authenticators. Authenticator LOGIN returned Swift_TransportException: Expected response code 235 but got code "535", with message "535-5.7.8 Username and Password not accepted. Learn more at
    535 5.7.8  https://support.google.com/mail/?p=BadCredentials 202sm24485739wmt.8 - gsmtp
    " in .../vendor/swiftmailer/swiftmailer/lib/classes/Swift/Transport/AbstractSmtpTransport.php:457
    Stack trace:
    #0 .../vendor/swiftmailer/swiftmailer/lib/classes/Swift/Transport/AbstractSmtpTransport.php(341): Swift_Transport_AbstractSmtpTransport->assertResponseCode('535-5.7.8 Usern...', Array)
    #1 .../vendor/swiftmailer/swiftmailer/lib/classes/Swift/Transport/EsmtpTransport.php(305): Swift_Transport_AbstractSmtpTransport->executeCommand('\r\n', Array, Array, false, NULL)
    #2 .../vendor/swiftmailer/swiftmailer/lib/classes/Swift/Transport/Esmtp/Auth/LoginAuthenticator.php(36): Swift_Transport_EsmtpTransport->executeCommand('\r\n', Array)
    #3 .../vendor/swiftmailer/swiftmailer/lib/classes/Swift/Transport/Esmtp/AuthHandler.php(177): Swift_Transport_Esmtp_Auth_LoginAuthenticator->authenticate(Object(Swift_Transport_EsmtpTransport), 'example@d...', '')
    #4 .../vendor/swiftmailer/swiftmailer/lib/classes/Swift/Transport/EsmtpTransport.php(371): Swift_Transport_Esmtp_AuthHandler->afterEhlo(Object(Swift_Transport_EsmtpTransport))
    #5 .../vendor/swiftmailer/swiftmailer/lib/classes/Swift/Transport/AbstractSmtpTransport.php(148): Swift_Transport_EsmtpTransport->doHeloCommand()
    #6 .../src/AppBundle/Service/Mailer/OptionsAwareTransport.php(68): Swift_Transport_AbstractSmtpTransport->start()
    #7 .../src/AppBundle/Controller/SystemStatusController.php(69): AppBundle\Service\Mailer\OptionsAwareTransport->realStart()
    #8 .../vendor/symfony/http-kernel/HttpKernel.php(151): AppBundle\Controller\SystemStatusController->checkMailerAction()
    #9 .../vendor/symfony/http-kernel/HttpKernel.php(68): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1)
    #10 .../vendor/symfony/http-kernel/Kernel.php(200): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
    #11 .../web/app_dev.php(49): Symfony\Component\HttpKernel\Kernel->handle(Object(Symfony\Component\HttpFoundation\Request))
    #12 {main}.
    ```
    
    In my opinion the exception message should only contain messages of the other exceptions, not their stack traces. For example the exception message above would be reduced to this:
    
    ```
    Failed to authenticate on SMTP server with username "example@domain.tld" using 1 possible authenticators. Authenticator LOGIN returned Expected response code 235 but got code "535", with message "535-5.7.8 Username and Password not accepted. Learn more at
    535 5.7.8  https://support.google.com/mail/?p=BadCredentials 202sm24485739wmt.8 - gsmtp ".
    ```
    
    Commits
    -------
    
    a5e697c Fix exception containing stack trace
  2. Fix exception containing stack trace

    enumag committed Jan 11, 2019
Commits on Dec 11, 2018
  1. minor #1156 Tweak phpunit config (fabpot)

    fabpot committed Dec 11, 2018
    This PR was merged into the 6.1-dev branch.
    
    Discussion
    ----------
    
    Tweak phpunit config
    
    <!-- Please fill in this template according to the PR you're about to submit. -->
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes/no
    | New feature?  | yes/no
    | Doc update?   | yes/no
    | BC breaks?    | yes/no
    | Deprecations? | yes/no
    | Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    
    <!-- Replace this comment by the description of your issue. -->
    
    Commits
    -------
    
    ab8cb9b tweaked phpunit config
  2. tweaked phpunit config

    fabpot committed Dec 11, 2018
Commits on Dec 10, 2018
  1. minor #1140 add php 7.3 to travis (andreybolonin)

    fabpot committed Dec 10, 2018
    This PR was merged into the 6.1-dev branch.
    
    Discussion
    ----------
    
    add php 7.3 to travis
    
    <!-- Please fill in this template according to the PR you're about to submit. -->
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | yes
    | Doc update?   | no
    | BC breaks?    | no
    | Deprecations? | no
    | Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    
    <!-- Replace this comment by the description of your issue. -->
    
    Commits
    -------
    
    451d6c1 add php 7.3 to travis
Commits on Dec 8, 2018
  1. minor #1153 Skip Swift_Smoke_HtmlWithAttachmentSmokeTest if the smoke…

    fabpot committed Dec 8, 2018
    … tests aren't run (derrabus)
    
    This PR was merged into the 6.1-dev branch.
    
    Discussion
    ----------
    
    Skip Swift_Smoke_HtmlWithAttachmentSmokeTest if the smoke tests aren't run
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | Doc update?   | no
    | BC breaks?    | no
    | Deprecations? | no
    | Fixed tickets | N/A
    | License       | MIT
    
    Currently, the unit tests fail if the smoke tests aren't configured to run. This PR fixes this.
    
    #SymfonyConHackday
    
    Commits
    -------
    
    5e5fbb0 Skip Swift_Smoke_HtmlWithAttachmentSmokeTest if the smoke tests aren't run.
  2. Skip Swift_Smoke_HtmlWithAttachmentSmokeTest if the smoke tests aren'…

    derrabus committed Dec 8, 2018
    …t run.
Commits on Nov 20, 2018
  1. minor #1146 Use dedicated assertRegExp assertion (carusogabriel)

    fabpot committed Nov 20, 2018
    This PR was merged into the 6.1-dev branch.
    
    Discussion
    ----------
    
    Use dedicated assertRegExp assertion
    
    <!-- Please fill in this template according to the PR you're about to submit. -->
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | Doc update?   | no
    | BC breaks?    | no
    | Deprecations? | no
    | Fixed tickets | - <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    
    Commits
    -------
    
    40e0613 Use dedicated assertRegExp assertion
Commits on Nov 19, 2018
  1. Use dedicated assertRegExp assertion

    carusogabriel committed Nov 19, 2018
Commits on Oct 29, 2018
  1. add php 7.3 to travis

    andreybolonin committed Oct 29, 2018
Commits on Sep 11, 2018
  1. bumped version to 6.1.4-DEV

    fabpot committed Sep 11, 2018
  2. prepared the 6.1.3 release

    fabpot committed Sep 11, 2018
  3. updated CHANGES

    fabpot committed Sep 11, 2018
  4. renamed a variable

    fabpot committed Sep 11, 2018
  5. feature #1126 Auto-start the SMTP transport when sending a message (f…

    fabpot committed Sep 11, 2018
    …abpot)
    
    This PR was merged into the 6.1-dev branch.
    
    Discussion
    ----------
    
    Auto-start the SMTP transport when sending a message
    
    Commits
    -------
    
    3daddb8 added auto-start of the transport when sending a message
  6. bug #1124 Tweak error message when response is empty (fabpot)

    fabpot committed Sep 11, 2018
    This PR was squashed before being merged into the 6.1-dev branch (closes #1124).
    
    Discussion
    ----------
    
    Tweak error message when response is empty
    
    <!-- Please fill in this template according to the PR you're about to submit. -->
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | yes
    | Doc update?   | no
    | BC breaks?    | o
    | Deprecations? | no
    | Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    
    <!-- Replace this comment by the description of your issue. -->
    
    Commits
    -------
    
    2ea9f8c added previous exception to exception
    5a6992d tweaked error message when response is empty
  7. minor #1125 Add finally support (fabpot)

    fabpot committed Sep 11, 2018
    This PR was merged into the 6.1-dev branch.
    
    Discussion
    ----------
    
    Add finally support
    
    Commits
    -------
    
    ed73052 added finally support
  8. added auto-start of the transport when sending a message

    fabpot committed Sep 11, 2018
  9. added finally support

    fabpot committed Sep 11, 2018
Older
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.