setBody() + addPart() with embedded images doesn't correctly add multipart/alternative entity

The following code:

@@@ php

setSubject('See my image'); $msg -> setFrom(array('swift@example.com')); $msg -> setTo(array('thunderbird@example.com'=>'Thunderbird Client')); $msg -> setBody("This is the plain text you'll see when I try and embed an image."); //Image to embed $cid = $msg->embed(Swift_Image::fromPath('logo.png')); $img = '

'; // HTML body $msg -> addPart( "

See my logo

" . "

Outlook works, Thunderbird will fall back to plain text and show the " . "HTML body (as Part 1.2) and the image as attachments

" . $img, ``` 'text/html' ``` ); //Transport and Mailer $transport = Swift_MailTransport::newInstance(); $mailer = Swift_Mailer::newInstance($transport); if($mailer->send($msg)) { echo "Message Sent"; } @@@ Creates a structure similar to the following: @@@ Content-Type: multipart/related; boundary="relbound" --relbound Content-Type: text/plain Plain text here --relbound Content-Type: text/html HTML here --relbound Content-Type: image/png --relbound-- @@@ There should be a multipart/alternative entity wrapping this: @@@ Content-Type: multipart/alternative; boundary="altbound" --altbound Content-Type: text/plain Plain text here --altbound Content-Type: multipart/related; boundary="relbound" --relbound Content-Type: text/html HTML here --relbound Content-Type: image/png --relbound-- --altbound-- @@@ Probably a simple fix (I seem to remember fixing a similar bug which should have test coverage now). Hopefully there's no conflict of logic between the two. Original creation date: 2009-03-23T09:06:36Z Original reporter: Ben Original ticket: http://swiftmailer.lighthouseapp.com/projects/21527/tickets/77

Note that the reason I say it's probably a simple fix is because replacing the setBody() call with an addPart() call fixes the problem. Swift Mailer is supposed to be automatically handling this inside the toByteStream() and toString() methods of Swift_Mime_SimpleMessage (or possibly Swift_Mime_MimePart).

Original creation date: 2009-03-23T09:08:24Z
Original reporter: Chris Corbyn

Using addPart instead works fine. However in Outlook Express it is still showing an "attachment" icon even though there are no attachments to download (since they are embedded).

Original creation date: 2009-07-30T19:00:08Z
Original reporter: Ben

[Gutza]

Is there any solution to this issue yet? I've been experimenting for several hours now, and I feel there must be a way to accomplish this just around the corner, but I just can't figure it out...

For the record, I've been able to successfully replicate the example at http://swiftmailer.org/docs/messages.html#embedding-existing-files -- but that's only about sending a pure HTML message. Instead, I want to send a multipart/related message containing both plain text and HTML content, with images embedded as explained above in the HTML part. This is the part that failed: the image either doesn't show at all, or it's an ordinary attachment.

[sstok]

@Gutza There is a similar issue with a work-around for this problem.
#184

[Gutza]

@sstok Thanks for the hint -- and yes, I can confirm that does indeed work with the current version. It's a silly work-around; but then again, all work-arounds are. :)

[jamesrgrinter]

I've encountered this problem, and I am already using setBody(.., 'text/html'), addBody(..., 'text/plain').

    $message = \Swift_Message::newInstance()
        ->setSubject($subject)
        ->setFrom($fromEmail)
        ->setTo($toEmail);
    $context['headerLogoEmbed'] = $message->embed(
        \Swift_Image::fromPath($imageFile)
    );
    // ... htmlBody and textBody rendered here 
    $message->setBody($htmlBody, 'text/html')
            ->addPart($textBody, 'text/plain');
    $this->mailer->send($message);

As well as the mutlipart/related and multipart/alternatives being in the wrong place (as noted above) the CID generated from the embed() doesn't match what is actually set for the image attachment after the setBody/addPart operations.

Using addPart() for the first (html, or text) part doesn't seem to help, either.

[TerjeBr]

The cid's does not match because of issue #534

[EdvinasBilius]

It's almost 2017 and this bug still exist.
Is there any possibility to fix it at last?

[mansoff]

Doesn't work in 2016 ....
I can't use embedded images and plain text together ....

[TerjeBr]

@EdvinasBilius and @mansoff does it work with the workaround in #184 ?

May be this should be closed as a duplicate of #184?

[mansoff]

@TerjeBr, no this is not working. Check in Thunderbird and use different text messages for HTML, PLAIN versions with embedded imges

[TerjeBr]

Thunderbird has some known issues. Look at the email source, and see if the error is with thunderbird or the email that is being sent out.

[tadaszelvys]

@TerjeBr it seems you're right, it is thunderbirds problem, other mail clients which can show plain text version of email (not source, but the actual message) works just fine.