New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add php 7.3 to travis #1140

Merged
merged 1 commit into from Dec 10, 2018

Conversation

Projects
None yet
5 participants
@andreybolonin
Copy link
Contributor

andreybolonin commented Oct 29, 2018

Q A
Bug fix? no
New feature? yes
Doc update? no
BC breaks? no
Deprecations? no
Fixed tickets #...
License MIT
@Rotzbua

This comment has been minimized.

Copy link
Contributor

Rotzbua commented Nov 1, 2018

Job for php 7.3 should be allowed to fail, because 7.3 is still not released. (edit: now it is released)

@carusogabriel

This comment has been minimized.

Copy link
Contributor

carusogabriel commented Nov 22, 2018

@Rotzbua We are less than a month from the release and if this package is passing the RC PHP 7.3, let's keep it passing :)

@gmponos

This comment has been minimized.

Copy link

gmponos commented Dec 9, 2018

ping 7.3 is released.

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Dec 10, 2018

Thank you @andreybolonin.

@fabpot fabpot merged commit 451d6c1 into swiftmailer:master Dec 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

fabpot added a commit that referenced this pull request Dec 10, 2018

minor #1140 add php 7.3 to travis (andreybolonin)
This PR was merged into the 6.1-dev branch.

Discussion
----------

add php 7.3 to travis

<!-- Please fill in this template according to the PR you're about to submit. -->

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| Doc update?   | no
| BC breaks?    | no
| Deprecations? | no
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT

<!-- Replace this comment by the description of your issue. -->

Commits
-------

451d6c1 add php 7.3 to travis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment