Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Smaller serialisation of messages. #167

Merged
merged 1 commit into from Feb 29, 2012

Conversation

Projects
None yet
3 participants
Contributor

williambailey commented Feb 27, 2012

Serialising messages results in a large serialised string with lots of duplicated data.

This is an initial attempt to reduce some of that information which should reduce spooler disk usage. I tried to to change too much and most of the changes involve moving shared data into class constants or static variables that get initialised once and ignored when the objects get serialised and unserialised.

Reduce amount of information serialised.
Serialising messages results in a late serialised string. This is an
initial attempt to reduce some of that information.

damianb commented Feb 28, 2012

considering this, it'd also likely reduce the memory usage OF swiftmailer too

Contributor

williambailey commented Feb 28, 2012

Sorry that should have said "I tried to NOT change too much" :)

fabpot added a commit that referenced this pull request Feb 29, 2012

merged branch williambailey/master (PR #167)
Commits
-------

d550dfc Reduce amount of information serialised.

Discussion
----------

Smaller serialisation of messages.

Serialising messages results in a large serialised string with lots of duplicated data.

This is an initial attempt to reduce some of that information which should reduce spooler disk usage. I tried to to change too much and most of the changes involve moving shared data into class constants or static variables that get initialised once and ignored when the objects get serialised and unserialised.

---------------------------------------------------------------------------

by damianb at 2012-02-28T04:02:03Z

considering this, it'd also likely reduce the memory usage OF swiftmailer too

---------------------------------------------------------------------------

by williambailey at 2012-02-28T07:44:24Z

Sorry that should have said "I tried to NOT change too much" :)

@fabpot fabpot merged commit d550dfc into swiftmailer:master Feb 29, 2012

makasim pushed a commit to formapro-forks/swiftmailer that referenced this pull request Jul 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment