This repository has been archived by the owner on Nov 17, 2021. It is now read-only.
No exception from Swift_Transport_AbstractSmtpTransport::__destruct #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Destructor should not throw any error because it leads to fatal error which cannot be handled.
|
This will resolve following issue: #819 |
|
Thank you @mzstic. |
fabpot
added a commit
that referenced
this pull request
Feb 13, 2017
…estruct (mzstic) This PR was squashed before being merged into the 5.x branch (closes #856). Discussion ---------- No exception from Swift_Transport_AbstractSmtpTransport::__destruct Destructor should not throw any error because it leads to fatal error which cannot be handled. When stream became invalid (broken pipe etc.), I was unable to terminate application without error. And as it is stated here little bit down: http://au2.php.net/__construct > Attempting to throw an exception from a destructor (called in the time of script termination) causes a fatal error. Commits ------- 9df19dd No exception from Swift_Transport_AbstractSmtpTransport::__destruct
makasim
pushed a commit
to formapro-forks/swiftmailer
that referenced
this pull request
Jul 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Destructor should not throw any error because it leads to fatal error which cannot be handled.
When stream became invalid (broken pipe etc.), I was unable to terminate application without error.
And as it is stated here little bit down: http://au2.php.net/__construct