C nested classes symbol table should be in global space #173

Merged
merged 1 commit into from May 12, 2014

Projects

None yet

2 participants

Contributor

No description provided.

@wsfulton wsfulton merged commit 55bda53 into swig:master May 12, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Owner

Thanks. I've added tests using %extend in 9b0e484 which is a good way to test the symbols are correct and is what the original bug reported as being broken (on swig-devel mailing list)

@wkalinin wkalinin deleted the wkalinin:csymbols branch May 12, 2014
Contributor

Oh, thanks for the test, that's what I should have done.

Owner

Unfortunately the tests didn't succeed with Octave and Javascript - https://travis-ci.org/swig/swig/builds/24953005. Looks like more needs doing for the cplusplusout feature. I've disabled this test for these languages for the moment, so master passes again.

There is a problem with the contents of the %extend, but a user can fix that up with the appropriate C++ scoping. However, the signatures of the %extend methods are generated incorrectly. Not sure if you fancy tackling that? It isn't the highest of priorities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment