Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Angular 17.x, suppress rfdc #1943

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions .browserslistrc

This file was deleted.

8 changes: 4 additions & 4 deletions .github/workflows/test_and_deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: 12.x

node-version: 20.11.x
- name: Install
uses: bahmutov/npm-install@v1

Expand All @@ -25,7 +25,7 @@ jobs:
npm run ci --if-present
env:
CI: true

- name: Prepare and deploy
run: |
npm run deploy -- --name="Swimlane" --email="swimlane-devops@swimlane.com"
Expand Down
54 changes: 39 additions & 15 deletions angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,17 @@
"outputPath": "dist/ngx-charts",
"index": "src/index.html",
"main": "src/main.ts",
"polyfills": "src/polyfills.ts",
"polyfills": [
"zone.js"
],
"tsConfig": "tsconfig.app.json",
"assets": ["src/favicon.ico", "src/assets"],
"styles": ["src/styles.scss"],
"assets": [
"src/favicon.ico",
"src/assets"
],
"styles": [
"src/styles.scss"
],
"scripts": [],
"allowedCommonJsDependencies": [
"emoji-flags",
Expand Down Expand Up @@ -75,36 +82,44 @@
"serve": {
"builder": "@angular-devkit/build-angular:dev-server",
"options": {
"browserTarget": "ngx-charts:build"
"buildTarget": "ngx-charts:build"
},
"configurations": {
"production": {
"browserTarget": "ngx-charts:build:production"
"buildTarget": "ngx-charts:build:production"
}
}
},
"extract-i18n": {
"builder": "@angular-devkit/build-angular:extract-i18n",
"options": {
"browserTarget": "ngx-charts:build"
"buildTarget": "ngx-charts:build"
}
},
"test": {
"builder": "@angular-devkit/build-angular:karma",
"options": {
"main": "src/test.ts",
"polyfills": "src/polyfills.ts",
"polyfills": [
"zone.js",
"zone.js/testing"
],
"tsConfig": "tsconfig.spec.json",
"karmaConfig": "karma.conf.js",
"assets": ["src/favicon.ico", "src/assets"],
"styles": ["src/styles.scss"],
"assets": [
"src/favicon.ico",
"src/assets"
],
"styles": [
"src/styles.scss"
],
"scripts": []
}
},
"lint": {
"builder": "@angular-eslint/builder:lint",
"options": {
"lintFilePatterns": ["src/**/*.ts"]
"lintFilePatterns": [
"src/**/*.ts"
]
}
},
"e2e": {
Expand All @@ -128,7 +143,7 @@
"prefix": "lib",
"architect": {
"build": {
"builder": "@angular-devkit/build-ng-packagr:build",
"builder": "@angular-devkit/build-angular:ng-packagr",
"options": {
"tsConfig": "projects/swimlane/ngx-charts/tsconfig.lib.json",
"project": "projects/swimlane/ngx-charts/ng-package.json"
Expand All @@ -150,11 +165,20 @@
"lint": {
"builder": "@angular-eslint/builder:lint",
"options": {
"lintFilePatterns": ["projects/swimlane/ngx-charts/src/**/*.ts"]
"lintFilePatterns": [
"projects/swimlane/ngx-charts/src/**/*.ts"
]
}
}
}
}
},
"defaultProject": "ngx-charts"
"schematics": {
"@angular-eslint/schematics:application": {
"setParserOptionsProject": true
},
"@angular-eslint/schematics:library": {
"setParserOptionsProject": true
}
}
}
5 changes: 5 additions & 0 deletions docs/changelog.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

## 21.0.0

- Breaking: Upgrade Angular to v17
- Fix: Remove rfdc

## 20.5.0

- Feature: Add Sankey diagram chart type
Expand Down
32 changes: 0 additions & 32 deletions karma.conf.js

This file was deleted.

Loading