"TypeError: root is not a function" when click on item named "watch" #93

Closed
hw-dwalter opened this Issue Nov 30, 2012 · 3 comments

Comments

Projects
None yet
2 participants

My firefox (17.0) raises an error wehn i click on the item named "watch". The following code demonstrates this behaviour:

$.contextMenu({
    selector: '.context-menu-one', 
    callback: function(key, options) {
        var m = "clicked: " + key;
        window.console && console.log(m) || alert(m); 
    },
    items: {
        "watch": {name: "Edit", icon: "edit"}
    }
});
Contributor

rodneyrehm commented Nov 30, 2012

woha, that's… interesting. I'll look into it. Fiddle

Contributor

rodneyrehm commented Nov 30, 2012

I've fixed this locally. There won't be a new version released until christmas, I think.

In the mean time you can patch this yourself, replace Line 743 with the following:

if ($.isFunction(root.callbacks[key]) && Object.prototype.hasOwnProperty.call(root.callbacks, key)) {

Thank you! That was really quick!

rodneyrehm added a commit that referenced this issue Dec 29, 2012

@rodneyrehm rodneyrehm closed this Dec 29, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment