Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

removed e.stopPropagation call in keyStop function #98

Closed
wants to merge 1 commit into from

2 participants

@coderaiser

Hi, first of all I want thank you for good library :).
I am using it in my application and sometime I need to check
is Esc-button presed and do some processing. But becaouse of
stopPropagation function I could not to know about it.
Is it realy necessary? Can we just drop it?
Or exclude in some situations?

@coderaiser coderaiser removed e.stopPropagation call in keyStop function
Hi, first of all I want thank you for good library :).
I am using it in my application and sometime I need to check
is Esc-button presed and do some processing. But becaouse of
stopPropagation function I could not to know about it.
Is it realy necessary? Can we just drop it?
Or exclude in some situations?
af78535
@rodneyrehm
Owner

Hey there,

yes, preventing the default action is required. Pressing the down arrow is supposed to select the next command, but not move the viewport.

We could export all internal event handlers $.contextMenu.handle = handle; to allow you to access the otherwise opaque handlers from the outside: $.contextMenu.handle.keyStop = $.noop;

@coderaiser

Okey, I think it would be the best solution. Thank you.

@rodneyrehm
Owner

superseded by #101 - fixed

@rodneyrehm rodneyrehm closed this
@coderaiser coderaiser deleted the unknown repository branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 23, 2012
  1. @coderaiser

    removed e.stopPropagation call in keyStop function

    coderaiser authored
    Hi, first of all I want thank you for good library :).
    I am using it in my application and sometime I need to check
    is Esc-button presed and do some processing. But becaouse of
    stopPropagation function I could not to know about it.
    Is it realy necessary? Can we just drop it?
    Or exclude in some situations?
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 2 deletions.
  1. +0 −2  src/jquery.contextMenu.js
View
2  src/jquery.contextMenu.js
@@ -426,8 +426,6 @@ var // currently active contextMenu trigger
if (!opt.isInput) {
e.preventDefault();
}
-
- e.stopPropagation();
},
key: function(e) {
var opt = $currentTrigger.data('contextMenu') || {},
Something went wrong with that request. Please try again.