Fix for PreparedStatement parameter setting #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Teradata 16.20 JDBC driver is 4.0, but Metabase expects 4.3, so here we are - back in the times before java.time. We will either have to override the relevant set-parameter functions same way as the read-column functions or use the legacy implementation of sql-jdbc.execute.
rawyler
approved these changes
Apr 22, 2020
Contributor
Author
|
Thx for the approval, I will merge it and release 1.0.1-metabase-v0.34.1-teradata-jdbc-16.20 later tonight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Teradata 16.20 JDBC driver is 4.0, but Metabase expects 4.3,
so here we are - back in the times before java.time.
We will either have to override the relevant set-parameter
functions same way as the read-column functions or use
the legacy implementation of sql-jdbc.execute.