New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can specify a custom Bonjour service type for the server. #56

Merged
merged 2 commits into from May 16, 2014

Conversation

2 participants
@jaanus
Copy link
Contributor

jaanus commented May 16, 2014

This PR adds a feature to be able to specify a custom Bonjour type for the server, instead of being hardcoded to the standard _http._tcp. Existing API-s do not change and continue to work as before, new API-s added to specify the custom type.

@swisspol

This comment has been minimized.

Copy link
Owner

swisspol commented May 16, 2014

Looks good but please remove these methods:

- (BOOL)startWithPort:(NSUInteger)port bonjourName:(NSString*)name bonjourType:(NSString*)bonjourType;
- (BOOL)runWithPort:(NSUInteger)port bonjourName:(NSString*)name bonjourType:(NSString*)bonjourType

Customizing the Bonjour type is an edge case and there's no need to "pollute" the API space with extra methods for it.

Removed unneeded API. If custom Bonjour type is needed, startWithOpti…
…ons should be used to specify an options dictionary with the custom type.
@jaanus

This comment has been minimized.

Copy link
Contributor

jaanus commented May 16, 2014

Thanks, cleaned up.

swisspol added a commit that referenced this pull request May 16, 2014

Merge pull request #56 from jaanus/customBonjourType
Can specify a custom Bonjour service type for the server.

@swisspol swisspol merged commit d1c7f9a into swisspol:master May 16, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@jaanus jaanus deleted the jaanus:customBonjourType branch May 16, 2014

@swisspol swisspol removed the enhancement label Aug 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment