Skip to content

Conversation

@learn-more
Copy link
Collaborator

@learn-more learn-more commented Feb 16, 2021

To test this, open the demo dialog,
Expand 'Inputs, Navigation & Focus' (last item)
Expand the 'Mouse cursors' (last item)

Hover over the lines describing the cursors.

Only tested on Windows 10.

image

image

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 55.613% when pulling f0115f7 on learn-more:add_cursor_hand into 480b4de on swistakm:master.

@learn-more
Copy link
Collaborator Author

@swistakm Would you have some time to take a look at this?

@Qlii256
Copy link

Qlii256 commented May 2, 2021

I was just trying to change the mouse cursor and can confirm it does not work with the latest PIP build. This integration seems to work fine! I also noticed that the MOUSE_CURSOR_HAND is missing as a constant, was this added in another commit because this "fix" does not include it.

@learn-more
Copy link
Collaborator Author

I was just trying to change the mouse cursor and can confirm it does not work with the latest PIP build. This integration seems to work fine! I also noticed that the MOUSE_CURSOR_HAND is missing as a constant, was this added in another commit because this "fix" does not include it.

This fix is based on the current pyimgui version, which includes an old imgui.
This hand cursor was added in a later imgui version.

@KinoxKlark KinoxKlark merged commit 99c22ac into pyimgui:master Aug 9, 2021
@KinoxKlark KinoxKlark added the release pending Merged but still needs official release label Aug 9, 2021
@learn-more learn-more deleted the add_cursor_hand branch August 9, 2021 10:45
@KinoxKlark KinoxKlark removed the release pending Merged but still needs official release label Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants