Updated ncm to new libnx ipc #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
fincs
approved these changes
Sep 24, 2019
yellows8
reviewed
Sep 24, 2019
yellows8
reviewed
Sep 24, 2019
|
Add |
yellows8
reviewed
Sep 24, 2019
yellows8
reviewed
Sep 24, 2019
yellows8
reviewed
Sep 24, 2019
|
Dedicated Close funcs for NcmContentStorage/NcmContentMetaDatabase which use serviceClose() have also been missing... |
…m-new-ipc # Conflicts: # nx/include/switch/services/ncm.h
yellows8
reviewed
Sep 25, 2019
yellows8
reviewed
Sep 25, 2019
yellows8
reviewed
Sep 25, 2019
yellows8
reviewed
Sep 25, 2019
yellows8
reviewed
Sep 25, 2019
yellows8
reviewed
Sep 25, 2019
|
Guess this wasn't really tested? A future PR which adds docs for all ncm funcs would be great too btw. |
|
I assume that comment is because of the ncmOpenContentMetaDatabase bug, that was because of bad copying and pasting after changing to use _ncmGetInterfaceInU8 (you can see it was fine prior to that). Prior to doing that I tested the main commands I use, as well as some of the more complicated new ones, but I don’t have test cases for each and every command, no. |
|
ok |
yellows8
reviewed
Sep 25, 2019
yellows8
reviewed
Sep 25, 2019
yellows8
reviewed
Sep 26, 2019
yellows8
reviewed
Sep 26, 2019
yellows8
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to use the new ipc setup, renamed various stuff to be more accurate, added all remaining commands