Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes #6

Closed
yellows8 opened this issue Feb 19, 2018 · 3 comments

Comments

@yellows8
Copy link
Collaborator

commented Feb 19, 2018

Probably should add support for themes eventually, but need to determine how to handle it.

@NicholeMattera

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2018

I was wondering if you started work on this, if not is it okay I pick this up? Did you have any ideas in mind for features?

  • Ability to set the colors in a (INI, JSON, YML) file?
  • Ability to select from themes inside of hbmenu?
  • Ability to have a background image?
  • Ability to theme the folder icon, and invalid icon?
  • Ability to hide the gradient bottom bar and waves?
@yellows8

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 5, 2018

That's fine - use libconfig. Never started implementing {anything config related}. EDIT: Background-image will affect perf, dunno if it's enough to matter.

EDIT2: Haven't decided how to handle light/dark system-theme with this either.

@yellows8

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 12, 2018

@StevenMattera Last+only commit for this on your branch was 2 months ago, did you stop working on it?

yellows8 added a commit that referenced this issue Sep 13, 2018
Implement Theming (#57)
* Implement theming and fix spelling errors, fixes issue #6.

Now requires libconfig
"separator" was spelled "seperator"

* Added default case for when the system theme is not the values for light/dark.

The default case acts like the system theme is the dark one.

@yellows8 yellows8 closed this Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.