From 5128972daad58722df6c89ed0c4aab68600bbe1a Mon Sep 17 00:00:00 2001 From: petruki <31597636+petruki@users.noreply.github.com> Date: Mon, 4 Sep 2023 11:37:27 -0700 Subject: [PATCH] Improved check config component perf --- src/middleware/validators.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/middleware/validators.js b/src/middleware/validators.js index d1f27ea..821be99 100644 --- a/src/middleware/validators.js +++ b/src/middleware/validators.js @@ -1,7 +1,6 @@ import { validationResult } from 'express-validator'; import { BadRequestError, responseException } from '../exceptions'; import { getConfig } from '../services/config'; -import { getComponents } from '../services/component'; import { getEnvironments } from '../services/environment'; export async function checkConfig(req, res, next) { @@ -17,10 +16,10 @@ export async function checkConfig(req, res, next) { } export async function checkConfigComponent(req, res, next) { - const componentFound = await getComponents( - { _id: req.config.components, name: req.component }); - - if (!componentFound.length) { + const hasComponent = req.config.components.filter((c) => + c.toString() === req.componentId.toString()).length > 0; + + if (!hasComponent) { return res.status(401).send({ error: `Component ${req.component} is not registered to ${req.config.key}` }); }