Skip to content

Conversation

@petruki
Copy link
Member

@petruki petruki commented Oct 13, 2025

This pull request introduces several improvements and bug fixes to the Switcher Client SDK, focusing on entry management, builder usability, and correctness in equality checks. The changes enhance the handling of strategy inputs, ensure proper flushing of entries, and add relevant tests for new behaviors.

Entry Management and Builder Enhancements:

  • Added a flush method to SwitcherBuilder to clear all previously added entries, improving usability and enabling easier reset of builder state.
  • Updated SwitcherBuilder.check to remove existing entries for the same strategy before adding a new one, preventing duplicate strategy inputs.
  • Changed logic in SwitcherRequest and SwitcherContextBase to use flush instead of resetEntry, standardizing entry clearing across the codebase. [1] [2] [3]

Correctness and Bug Fixes:

  • Fixed the Entry.equals method to correctly return false when objects are not equal, ensuring proper equality checks.

@petruki petruki added this to the v1.9.2 milestone Oct 13, 2025
@petruki petruki self-assigned this Oct 13, 2025
@petruki petruki added the patch Updating internal dependencies label Oct 13, 2025
@sonarqubecloud
Copy link

@petruki petruki merged commit a2a22b5 into master Oct 13, 2025
22 of 24 checks passed
@petruki petruki deleted the staging branch October 13, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Updating internal dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants