Fix unexpected swoole sever crash on high concurrency operation #2214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SplQueue` is operated using `enqueue()` and `dequeue()` not with `push()` and `pop()` which is for `Stack`. `SplQueue is a FIFO`, but use of push/pop turns it into Stack which is LIFO, this has caused numerous disconnections that resulted into a swoole server crash. By fixing this, disconnection from database server does not cause server crash anymore. Ref. SplQueue dequeue -> http://php.net/manual/en/splqueue.dequeue.php SplQueue enqueue -> http://php.net/manual/en/splqueue.enqueue.php
Author
|
Code in here should be updated as well https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/frameworks/PHP/swoole/swoole-server.php However, it seems that the benchmark did not capture this since it was not testing concurrency thoroughly. |
Indribell
added a commit
to Indribell/FrameworkBenchmarks
that referenced
this pull request
Dec 17, 2018
See issue TechEmpower#2214 from Swoole reporting: swoole/swoole-src#2214
`SplQueue` is operated using `enqueue()` and `dequeue()` not with `push()` and `pop()` which is for `Stack`. `SplQueue` is a `FIFO`, but use of `push/pop` turns it into `Stack` which is `LIFO`, this has caused numerous disconnections that resulted into a swoole server crash. By fixing this, disconnection from database server does not cause server crash anymore. Ref. [SplQueue dequeue](http://php.net/manual/en/splqueue.dequeue.php) [SplQueue enqueue](http://php.net/manual/en/splqueue.enqueue.php)
`SplQueue` is operated using `enqueue()` and `dequeue()` not with `push()` and `pop()` which is for `Stack`. `SplQueue` is a `FIFO`, but use of `push/pop` turns it into `Stack` which is `LIFO`, this has caused numerous disconnections that resulted into a swoole server crash. By fixing this, disconnection from database server does not cause server crash anymore. Ref. [SplQueue dequeue](http://php.net/manual/en/splqueue.dequeue.php) [SplQueue enqueue](http://php.net/manual/en/splqueue.enqueue.php)
NateBrady23
pushed a commit
to TechEmpower/FrameworkBenchmarks
that referenced
this pull request
Dec 17, 2018
* Updated Swoole version from 2.1.3 to 4.2.9 * Changed push/pop to enqueue/dequeue See issue #2214 from Swoole reporting: swoole/swoole-src#2214
|
Great @jobs-git 👍 |
Member
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SplQueueis operated usingenqueue()anddequeue()not withpush()andpop()which is forStack.SplQueueis aFIFO, but use ofpush/popturns it intoStackwhich isLIFO, this has caused numerous disconnections that resulted into a swoole server crash.By fixing this, disconnection from database server does not cause server crash anymore.
Ref.
SplQueue dequeue
SplQueue enqueue