Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins after the first one sometimes don't draw #317

Closed
pjreed opened this issue Feb 4, 2016 · 0 comments
Closed

Plugins after the first one sometimes don't draw #317

pjreed opened this issue Feb 4, 2016 · 0 comments
Assignees
@pjreed
Labels
bug

Comments

@pjreed
Copy link
Contributor

pjreed commented Feb 4, 2016

PR #306 introduced a bug that caused the OpenGL viewport to become un-transformed properly after the first plugin was drawn, which could make subsequent plugins not render properly.
@pjreed pjreed self-assigned this Feb 4, 2016
pjreed added a commit to pjreed/mapviz that referenced this issue Feb 4, 2016
@pjreed
Fixing swri-robotics#317
23d787f 
First, the model view matrix needs to be saved and restored around
QPainter operations because Qt clears several GL variables.  Also, the
image plugin needed to explicitly call glMatrixMode(GL_PROJECTION);
it does a few operations on the projection matrix and was just assuming
that was the current matrix mode.  Also, I added a function that plugins
need to override if they want to do QPainter operations; this will
eliminate unnecessary overhead for plugins that do not.
@pjreed pjreed added the bug label Feb 4, 2016
@pjreed pjreed mentioned this issue Feb 4, 2016
Closed
@elliotjo elliotjo mentioned this issue Feb 4, 2016
Merged
pjreed added a commit to pjreed/mapviz that referenced this issue Feb 4, 2016
@pjreed
Fixing swri-robotics#317
38f2a6e 
First, the model view matrix needs to be saved and restored around
QPainter operations because Qt clears several GL variables.  Also, the
image plugin needed to explicitly call glMatrixMode(GL_PROJECTION);
it does a few operations on the projection matrix and was just assuming
that was the current matrix mode.  Also, I added a function that plugins
need to override if they want to do QPainter operations; this will
eliminate unnecessary overhead for plugins that do not.
malban pushed a commit that referenced this issue Feb 5, 2016
Merge pull request #318 from pjreed/fix-317
860c87a 
Fixing #317; weird plugin transformation glitches
pjreed added a commit that referenced this issue Feb 5, 2016
@pjreed
Merge pull request #321 from pjreed/fix-317-jade
65c0169 
Porting fix #317 to jade-devel
@pjreed pjreed closed this as completed Feb 5, 2016
malban pushed a commit to malban/mapviz that referenced this issue Jul 6, 2016
@pjreed
Fixing the .travis.yml file. Fixes swri-robotics#317.
0a2c75f
malban pushed a commit to malban/mapviz that referenced this issue Jul 6, 2016
@pjreed
Fixing the .travis.yml file. Fixes swri-robotics#317.
1cb7d95 
Conflicts:
	.travis.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjreed pjreed

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pjreed