Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odometry Plugin Icon No Longer Shows Correct Color #426

Closed
evenator opened this issue Sep 9, 2016 · 0 comments
Assignees
Labels
bug

Comments

@evenator
Copy link
Contributor

@evenator evenator commented Sep 9, 2016

The color of the icon for odometry plugins no longer matches the selected display color. I think this regression was introduced in #382. I haven't confirmed this bug yet, but I've heard multiple reports around the lab, and I wanted to get it down before I forget again.

This may also affect other point drawing plugins with selectable colors, i.e. LaserScan, PointCloud, GPS.

@evenator evenator added the bug label Sep 9, 2016
@evenator evenator self-assigned this Sep 9, 2016
@pjreed pjreed self-assigned this Oct 4, 2016
pjreed added a commit to pjreed/mapviz that referenced this issue Oct 4, 2016
This was probably broken back when all of these were refactored to have a
single base class.  It looks like the member variable that holds the color
used to draw the icon was never actually being updated.

Fixes swri-robotics#426
@evenator evenator closed this in #433 Oct 5, 2016
evenator added a commit that referenced this issue Oct 5, 2016
This was probably broken back when all of these were refactored to have a
single base class.  It looks like the member variable that holds the color
used to draw the icon was never actually being updated.

Fixes #426
pjreed added a commit to pjreed/mapviz that referenced this issue Oct 6, 2016
This was probably broken back when all of these were refactored to have a
single base class.  It looks like the member variable that holds the color
used to draw the icon was never actually being updated.

Fixes swri-robotics#426
pjreed added a commit to pjreed/mapviz that referenced this issue Oct 6, 2016
This was probably broken back when all of these were refactored to have a
single base class.  It looks like the member variable that holds the color
used to draw the icon was never actually being updated.

Fixes swri-robotics#426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.