Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to use non deprecated pluginlib macro #493

Merged
merged 1 commit into from Oct 31, 2017

Conversation

Projects
None yet
2 participants
@mikaelarguedas
Copy link
Contributor

commented Oct 27, 2017

These macros, deprecated for now 8 years, will be removed in the next ROS release (ROS Melodic)

This change will allow the code to keep compiling on future ROS versions

Note: When replacing the macros I noticed you had your own SWRI_NODELET_EXPORT_CLASS macro so I modified all nodelets to use it

@pjreed

This comment has been minimized.

Copy link
Member

commented Oct 31, 2017

Thanks again!

@pjreed pjreed merged commit 0748672 into swri-robotics:master Oct 31, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mikaelarguedas mikaelarguedas deleted the mikaelarguedas:update_pluginlib_macros branch Oct 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.