-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend terminal support #12
Comments
The terminal I use also supports images, but it uses its own escape sequences: https://github.com/billiob/terminology Maybe it's simply enough that you guys could implement it. |
I'd appreciate a pull request, to be honest; I can't test that terminal myself. |
DomTerm supports not only inline images and links but also inline html.
The main issue with the above pipeline is the relative URLs aren't handled well at this point (though I'm thinking of the best way to deal with it). The
I don't know Rust but it seems mdcat could easily add DomTerm support by wrapping the output of pulldown-cmark with the above-mentioned escape sequence. Preferably you'd want to convert URLs to |
@PerBothner I can add support for DomTerm to the inline HTML code—though I don't have much time and would prefer a pull request. But I wonder whether I need to: If DomTerm supports HTML why not use one of the many Markdown-to-HTML converters instead? 🤔 These tools produce leverage the full syntax of HTML and normally produce much better output than |
Two reasons I can think of:
Perhaps Now whether these reasons are strong enough to add DomTerm support to mdcat is a different issue. Ideally, yes, but given limited resources I understand if you don't make it top priority :-) |
@PerBothner I was just wondering, but I see your point now. That said it's not my intention to make I'll look into this when I've got some spare time perhaps, but I'd really appreciate a pull request to be honest. It's not quite trivial: We must add HTML to |
to add another terminal, kitty created its own graphics protocol: https://sw.kovidgoyal.net/kitty/index.html perhaps you could use the ranger tui file manager as a rosetta stone; it supports drawing images in iterm2, terminology, urxvt, and kitty https://github.com/ranger/ranger |
Thanks but I won’t add that myself. I don’t have the time. I’m closing this issue; I don’t intend to add further terminal emulators myself. Please open a pull request to add support for this terminal emulator if you like. |
Figure out whether other terminal emulators support iTerm2 features and extend the list of supported terminals accordingly.
The text was updated successfully, but these errors were encountered: