Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify registration recommendations #1328

Merged
merged 2 commits into from Feb 11, 2019

Conversation

wthrowe
Copy link
Member

@wthrowe wthrowe commented Feb 7, 2019

This change makes derived classes using FakeVirtual stuff usable as
concrete classes without specifying the registrars parameter. All
current uses of the registration framework fall into this category.

Proposed changes

Types of changes:

  • Bugfix
  • New feature

Component:

  • Code
  • Documentation
  • Build system
  • Continuous integration

Code review checklist

  • The PR passes all checks, including unit tests, clang-tidy and IWYU.
    For instructions on how to perform the CI checks locally refer to the Dev
    guide on the Travis CI
    .
  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.

Further comments

This change makes derived classes using FakeVirtual stuff usable as
concrete classes without specifying the registrars parameter.  All
current uses of the registration framework fall into this category.
@kidder
Copy link
Member

kidder commented Feb 11, 2019

Travis failures are from #1031

@kidder kidder merged commit 3a59de6 into sxs-collaboration:develop Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants