Construct ObservationId directly from a value #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsvu
requested review from
nilsdeppe,
markscheel and
wthrowe
and removed request for
nilsdeppe and
markscheel
nilsvu
force-pushed
the
linsolv_iteration_id
branch
from
4fb16bc
to
3c3b1fb
Compare
|
Yes, this looks good. |
|
I'll review, but might not have time until Tuesday or Wednesday :) |
|
@wthrowe How should we handle time here? I can think of the following options:
|
nilsvu
force-pushed
the
linsolv_iteration_id
branch
2 times, most recently
from
f1c447b
to
29a4466
Compare
|
Use |
|
@wthrowe I made the changes, this should be ready for review now |
nilsvu
force-pushed
the
linsolv_iteration_id
branch
2 times, most recently
from
2b2c24a
to
f761f2e
Compare
wthrowe
requested changes
Mar 5, 2019
| @@ -81,11 +55,11 @@ SPECTRE_TEST_CASE("Unit.IO.Observers.ObservationId", "[Unit][Observers]") { | |||
| CHECK(id4.observation_type_hash() != id3.observation_type_hash()); | |||
| CHECK(id4.value() == 8.0); | |||
|
|
|||
| ObservationId time0(Time(Slab{0.0, 1.0}, 0), | |||
| ObservationId time0(Time(Slab{0.0, 1.0}, 0).value(), | |||
There was a problem hiding this comment.
This section (everything with the timeN objects) is a duplicate of the preceding section now.
|
fixed @wthrowe. @nilsdeppe and/or @markscheel please review |
nilsvu
force-pushed
the
linsolv_iteration_id
branch
3 times, most recently
from
ce865c7
to
4871636
Compare
|
Looks good. |
nilsvu
force-pushed
the
linsolv_iteration_id
branch
from
4871636
to
e87d3fa
Compare
|
Rebased and squashed |
We don't need the wrapper anymore since ObservationId can now construct directly from a value
nilsvu
force-pushed
the
linsolv_iteration_id
branch
from
e87d3fa
to
7f99a89
Compare
|
Rebased on #1385 |
nilsdeppe
approved these changes
Mar 11, 2019
markscheel
approved these changes
Mar 11, 2019
kidder
approved these changes
Mar 11, 2019
|
@wthrowe please look at; you previously gave the go ahead for a squash, so it should be quick; please merge if you are happy with it. |
wthrowe
approved these changes
Mar 12, 2019
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR changes the constructor of
ObservationIdto take adouble valuedirectly, instead of a type that has avalue()member function. This allows me to remove the wrapper aroundsize_tthat I used for theLinearSolver::IterationId. I haven't propagated the change to the other places that constructObservationIdyet, so opening this as a draft PR to confirm the design.Types of changes:
Component:
Code review checklist
clang-tidyandIWYU.For instructions on how to perform the CI checks locally refer to the Dev
guide on the Travis CI.
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.