Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images over 5MB shouldn't be used #485

Closed
sybrew opened this issue Nov 6, 2019 · 4 comments
Closed

Images over 5MB shouldn't be used #485

sybrew opened this issue Nov 6, 2019 · 4 comments
Labels
[Impact] Performance [Impact] Twitter [Type] Bug [Type] Feature Something new we need to write from the ground up.
Milestone

Comments

@sybrew
Copy link
Owner

sybrew commented Nov 6, 2019

From freshcreate's report:

We should skip/filter out images that are over 5MB in size because Twitter doesn't support these.

There's performance overhead involved, i.e., testing each subsequent file for its size isn't fast by any means, especially when the files are offloaded to a different server.

So, we'd prefer using WordPress' stored metadata. For that, WordPress needs to populate the filesize field first — see https://core.trac.wordpress.org/ticket/47459. Until then, this issue is marked as "Won't fix."

@sybrew
Copy link
Owner Author

sybrew commented Nov 26, 2019

From codebot's suggestion:

Allow users to specify a preferred registered size, from 'full', to anywhere below.

When such a size is no longer registered, we should default to 'full'. This can be a bit sporadic since themes define their image sizes way after plugins_loaded. Nevertheless, it'd be a welcome addition.

Alternatively, we could allow users to specify the maximum size in pixels. This will be more reliable since the image parser always asserts this value, and it goes over the registered image sizes for each image individually. Moreover, older images may not have been downsized to presently registered image sizes.

@sybrew sybrew added the [Type] Feature Something new we need to write from the ground up. label Nov 26, 2019
@sybrew
Copy link
Owner Author

sybrew commented Feb 20, 2020

A patch for filesize registration has been submitted. We might be able to implement this feature sooner than later.

See: https://core.trac.wordpress.org/ticket/49412

@sybrew sybrew added [Status] Blocked Awaiting another feature or change. and removed [Status] Won't fix A reason should be supplied... labels Feb 20, 2020
@sybrew sybrew added this to the 4.2.0 milestone Nov 5, 2020
@sybrew sybrew modified the milestones: 4.2.0, 4.3.0 Nov 4, 2021
@sybrew
Copy link
Owner Author

sybrew commented Mar 10, 2022

https://core.trac.wordpress.org/ticket/49412 is merged for WP 6.0, removing the blocker.

@sybrew sybrew removed the [Status] Blocked Awaiting another feature or change. label Mar 10, 2022
@sybrew
Copy link
Owner Author

sybrew commented Apr 30, 2022

Facebook now accepts images up to 8MB, but that doesn't mean other social networks allow this. We'll stick to 5MB and add a filter for those wanting more.

@sybrew sybrew modified the milestones: 4.3.0, 4.2.4 May 3, 2022
@sybrew sybrew closed this as completed in d523d4f May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Impact] Performance [Impact] Twitter [Type] Bug [Type] Feature Something new we need to write from the ground up.
Projects
None yet
Development

No branches or pull requests

1 participant