Remove the thirdparty.zip malarkey. Potentially significant performance win, #35

Open
wants to merge 1 commit into
from

1 participant

@jamezpolley
Sydney Linux User Group member

significant decrease in complexity of maintaining the app, at a
cost of bumping the number of files to be uploaded from just over 200 to
just over 300.

If we ever need this back, it's in the git history and we can pull it back out.

@jamezpolley jamezpolley Remove the thirdparty.zip malarkey. Potentially significant performance
win, significant decrease in complexity of maintaining the app, at a
cost of bumping the number of files to be uploaded from just over 200 to
just over 300.
7350313
@jamezpolley
Sydney Linux User Group member

Exact numbers:

the version7 branch:
Cloning 40 static files.
Cloning 144 application files

Current master branch:
Cloning 40 static files.
Cloning 148 application files.

After this patch:
Cloning 40 static files.
Cloning 277 application files.

The limit is 3k files. We have a long way to go before the zip functionality helps us in any way at all.

@jamezpolley
Sydney Linux User Group member

After talking to other people yesterday, it seems as though the performance gain here is probably not as significant as I had thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment