Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Spacemacs home buffer should use `bookmark-jump` for bookmarks #2431
I have a bookmark to a PDF file that bookmarks to a specific page in the file. If I use
I read the code for
So instead of just using file links as in the recent files list, visiting the link should call
I may try attacking this, but I thought I would submit the bug to get ideas from @syl20bnr and others. Any guidance on the cleanest way to solve this, let me know. I totally want to do a PR for this.
This has been annoying me as well for some time.
One solution is to make a new function "insert-bookmark-list" which basically does the same as "insert-file-list" but use bookmark-jump instead of find-file:
And then you need to change a line in the insert-startupify-lists:
However, I'm far from sure this is the cleanest way! Duplicating the insert-*-list function doesn't feel quite right. Looking forward to see some guidance from the lisp experts :-)
Well, from what I see the number of things you need to change is two:
You could do this with optional arguments, say, but I'm not convinced the extra complexity is worth it. Might be simpler just to make a new function.
Seems like a great entry level issue. No need for a lisp expert. :-)