Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default emacs theme question #4723

Closed
gguimaraesbr opened this issue Jan 21, 2016 · 20 comments
Closed

Default emacs theme question #4723

gguimaraesbr opened this issue Jan 21, 2016 · 20 comments

Comments

@gguimaraesbr
Copy link

What if I want to use the default emacs theme? Is it possible? I tried setting dotspacemacs-themes to nil but it doesn't work.

Thanks!

@izahn
Copy link
Contributor

izahn commented Jan 21, 2016

You can get part of the way there with

  (while custom-enabled-themes
    (disable-theme (car custom-enabled-themes)))

@cpaulik
Copy link
Contributor

cpaulik commented Jan 22, 2016

I think this is a bug. In SPC T h the default theme is an option. But putting default in dotspacemacs-themes gives an error because spacemacs looks for a melpa package default-theme

@izahn
Copy link
Contributor

izahn commented Jan 22, 2016

I don't think this counts as a bug, though possibly a missing feature. The thing is, there is no "default" theme. The "default" theme is just what you get when you disable all custom themes. If you look at helm-themes [1] you'll see that it first disables any custom themes with (mapc 'disable-theme custom-enabled-themes) (this being a smarter version of my while loop in the earlier comment), and then it does nothing if the selected them is "default".

All that said, it probably is a good idea to have a way of running spacemacs without a custom them. I've submitted a PR (#4757) that allows setting default in dotspacemacs-themes, in which case no theme will be enabled.

[1] https://github.com/syohex/emacs-helm-themes/blob/7d0d457f1f14492805b2766937a2df55fe665375/helm-themes.el#L34

@syl20bnr
Copy link
Owner

Built-in themes are supported. I don't recall the name of the default theme but I'm pretty sure it has another name than default.

Can you try with another built-in theme name ?

@izahn
Copy link
Contributor

izahn commented Jan 22, 2016

I think what we're after here is the "theme" you get if you start emacs with emacs -Q. There is no theme for that; it is the absense of a custom theme. The problem is not that built-in themes don't work, but rather that we want to be able to starr emacs without enableing any theme.

@madand
Copy link
Contributor

madand commented Jun 23, 2016

The fix is also in master for a while. The code

dotspacemacs-themes '(default)

works as expected. So the issue may be closed.

@shankmittal
Copy link

dotspacemacs-themes '(default) doesn't work anymore on new spacemacs

@dangom
Copy link
Contributor

dangom commented Jun 15, 2017

Any updates on this?

@TheBB
Copy link
Collaborator

TheBB commented Jun 16, 2017

I pushed a fix, check now.

@duianto
Copy link
Collaborator

duianto commented Jun 16, 2017

It seems to be working:

emacs_2017-06-16_17-36-31

This is probably a separate issue, but I switched to an older branch while I was testing, and the message:

error: (error Unable to find theme file for ‘default’)

appears twice in the *Messages* buffer, 3rd from the top

Loading c:/Users/Username/AppData/Roaming/.emacs.d/core/core-load-paths.el (source)...done
Loading c:/Users/Username/AppData/Roaming/.spacemacs...done
error: (error Unable to find theme file for ‘default’)
Setting the font...
PNG warning: Interlace handling should be turned on when using png_read_image
Open the quickhelp.

and line 60-70 something (the Spacemacs home buffer was open before restarting, therefore it opened on startup):

Loading c:/Users/Username/AppData/Roaming/.emacs.d/layers/+source-control/version-control/keybindings.el (source)...done
Loading c:/Users/Username/AppData/Roaming/.emacs.d/.cache/spacemacs-buffer.el (source)...done
Spacemacs is ready.
error: (error Unable to find theme file for ‘default’)
Loading c:/Users/Username/AppData/Roaming/.emacs.d/.cache/recentf...done
Open the quickhelp.
Skipping check for new version (reason: dotfile)
[yas] Prepared just-in-time loading of snippets successfully.

is the theme loading twice?

The message

Open the quickhelp

also appears twice.

System Info 💻

  • OS: windows-nt
  • Emacs: 25.2.2
  • Spacemacs: 0.200.9
  • Spacemacs branch: develop (rev. 9424430)
  • Graphic display: t
  • Distribution: spacemacs
  • Editing style: vim
  • Completion: helm
  • Layers:
(helm auto-completion emacs-lisp git markdown
      (org :variables org-agenda-files
           '("c:/Users/Username/Documents/"))
      version-control)
  • System configuration features: XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS MODULES

@TheBB
Copy link
Collaborator

TheBB commented Jun 16, 2017

error: (error Unable to find theme file for ‘default’)

That's exactly what I fixed. Not surprising that you see it on a different branch that doesn't have the fix.

@duianto
Copy link
Collaborator

duianto commented Jun 16, 2017

The question was, since it's reported twice in the messages buffer, is the theme loaded twice? Or since the "Open the quickhelp" message also appears twice, is there something else going on?

@dangom
Copy link
Contributor

dangom commented Jun 17, 2017

It works now, but my modeline is still messed up, i.e., black fonts on a black background.

screen shot 2017-06-17 at 12 18 16

@TheBB
Copy link
Collaborator

TheBB commented Jun 17, 2017

@duianto If the theme fails to load early in the boot process, it will load the fallback theme (spacemacs-dark) and attempt to load it again after packages have been fully initialized. So yeah, if there's an error, it will try to do it twice.

@TheBB
Copy link
Collaborator

TheBB commented Jun 17, 2017

@dangom Those are the default colours for the powerline faces, I believe.

@ghost
Copy link

ghost commented May 4, 2018

I also have issues with choosing the default theme as default :D A workaround for me is to just put the default theme on the 2nd to last position in dotspacemacs-themes and switch to it once emacs starts with SPC T n.

@AlexDaniel
Copy link

Yeah, and it seems like it needs something like this also:

   dotspacemacs-mode-line-theme '(spacemacs)

Otherwise the modeline is sorta broken.

@gnumonk
Copy link

gnumonk commented Jan 25, 2019

This is still not working with the latest
Warnings:

  • An error occurred while applying the theme "default", fallback on theme
    "spacemacs-dark". Error was: (error Unable to find theme file for ‘default’)
  • Please check the value of "dotspacemacs-themes" in your dotfile or open an issue
    so we can add support for the theme "default".

Spacemacs v.0.200.13

Below variable set in .spacemacs

dotspacemacs-themes '(default)

@sdwolfz sdwolfz added this to the Bugfix Release 0.300.1 milestone Jan 25, 2019
@Compro-Prasad
Copy link
Contributor

@gnumonk I don't think master has the same changes as in develop. For me, it works on the develop branch.

@equwal
Copy link

equwal commented Jun 23, 2019

This works (putting the theme as "default") on the current spacemacs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests