Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evil-surround doesn't work in helm-ag-edit #9542

Closed
jdelStrother opened this issue Sep 5, 2017 · 5 comments
Closed

evil-surround doesn't work in helm-ag-edit #9542

jdelStrother opened this issue Sep 5, 2017 · 5 comments
Labels
- Bug tracker - stale marked as a stale issue/pr (usually by a bot)

Comments

@jdelStrother
Copy link
Contributor

jdelStrother commented Sep 5, 2017

Description :octocat:

evil-surround doesn't work in helm-ag-edit

Reproduction guide 🪲

  • Start Emacs
  • Open a project
  • search for something with SPC /
  • start helm-ag-edit with C-c C-e
  • move to a word, and type ysw} to try and surround the word in {...}

Observed behaviour: 👀 💔
After typing ys I see Quit in the minibuffer, then the w} just jump my cursor around

Expected behaviour: ❤️ 😄
The current word gets surrounded with brackets

System Info 💻

  • OS: darwin
  • Emacs: 26.0.50
  • Spacemacs: 0.200.9
  • Spacemacs branch: develop (rev. 2bd0811)
  • Graphic display: t
  • Distribution: spacemacs
  • Editing style: vim
  • Completion: helm
  • Layers:
(csv sql nginx markdown yaml helm auto-completion docker emacs-lisp flow-type
     (git :variables git-use-magit-next t)
     (github :variables magithub-cache t)
     go helm html
     (javascript :variables js2-mode-show-parse-errors nil js2-mode-show-strict-warnings nil)
     osx react
     (ruby :variables ruby-test-runner 'rspec ruby-version-manager 'rvm ruby-align-to-stmt-keywords
           '(def if))
     shell syntax-checking vinegar)
  • System configuration features: JPEG RSVG IMAGEMAGICK NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES

Notes

If I manually start fundamental-mode within helm-ag-edit mode, evil-surround works fine, though that then breaks the helm-ag-edit session.

@duianto
Copy link
Collaborator

duianto commented Sep 5, 2017

Confirmed

System Info 💻

  • OS: windows-nt
  • Emacs: 26.0.50
  • Spacemacs: 0.200.9
  • Spacemacs branch: develop (rev. 3208cc9)
  • Graphic display: t
  • Distribution: spacemacs
  • Editing style: vim
  • Completion: helm
  • Layers:
(autohotkey auto-completion colors emacs-lisp git helm markdown org version-control)
  • System configuration features: XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS MODULES

@CeleritasCelery
Copy link
Contributor

Sounds like a key binding precedence issue

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Feb 28, 2020
@duianto
Copy link
Collaborator

duianto commented Feb 29, 2020

The issue is still occurring.

The first time the *helm-ag-edit* buffer is opened, then ysiw} works on an editable part of the buffer (to the right of the file path and line number).

evil-surround-mode is a variable defined in ‘evil-surround.el’.
Its value is t
Local in buffer helm-ag-edit; global value is nil

The second or more times the *helm-ag-edit* buffer is opened, then the variable is disabled:

evil-surround-mode is a variable defined in ‘evil-surround.el’.
Its value is nil

Windows 1903
#### System Info :computer:
- OS: windows-nt
- Emacs: 26.3
- Spacemacs: 0.300.0
- Spacemacs branch: develop (rev. 2032360f7)
- Graphic display: t
- Distribution: spacemacs
- Editing style: vim
- Completion: helm
- Layers:
```elisp
(autohotkey auto-completion c-c++ command-log emacs-lisp git github
            (gnus :variables gnus-summary-thread-gathering-function 'gnus-gather-threads-by-subject)
            go helm imenu-list javascript
            (markdown :variables markdown-live-preview-engine 'vmd markdown-command "vmd")
            multiple-cursors org pdf
            (shell :variables shell-default-shell 'shell shell-default-height 30 shell-default-position 'bottom)
            spell-checking syntax-checking treemacs version-control)
```
- System configuration features: XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS THREADS LCMS2

@duianto duianto added - Bug tracker - and removed stale marked as a stale issue/pr (usually by a bot) labels Mar 8, 2020
@github-actions
Copy link

github-actions bot commented Mar 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- Bug tracker - stale marked as a stale issue/pr (usually by a bot)
Projects
None yet
Development

No branches or pull requests

3 participants