New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #11761 - update lsp go/ts/react/rust #11765

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
4 participants
@jamartin9
Copy link

jamartin9 commented Dec 28, 2018

Remove lsp-go package for lsp built in.
Changed go/react/typescript lsp-*-enable hooks to lsp
Update go/typescript/rust layer docs for lsp-mode installation command.
Remove unused rust layer variable and docs

@jamartin9 jamartin9 changed the title Fixes #11761 Fixes #11761 - update lsp go/ts/react Dec 28, 2018

@sdwolfz sdwolfz added this to the Release 0.300 milestone Dec 30, 2018

@ethanrubio

This comment has been minimized.

Copy link

ethanrubio commented Jan 4, 2019

@jamartin9 should the docs for the go lang layer be updated as well since the LSP used in lsp-mode is now bingo and not the sourcegraph one as mentioned here?

@jamartin9 jamartin9 force-pushed the jamartin9:update-go-ts-react-lsp branch from 7008ed0 to 39027aa Jan 4, 2019

@jamartin9

This comment has been minimized.

Copy link

jamartin9 commented Jan 4, 2019

@ethanrubio I believe you are correct and the documentation should be updated. Thanks and good catch on the documentation desync. I updated the Go/Typescript layer documentation to point to lsp-mode instructions since both are out of date. Hopefully pointing to the source material will prevent further drift.

@blasut

This comment has been minimized.

Copy link

blasut commented Jan 8, 2019

Anymore testing or work that needs to happen with this? I'm happy to help out if something is needed.

@sdwolfz

This comment has been minimized.

Copy link
Collaborator

sdwolfz commented Jan 8, 2019

I wanted to merge this after finishing #11741 as my time is verry limited right now. But if you can confirm that everything is indeed working properly then I can do a final sanity check and merge it in.

@blasut

This comment has been minimized.

Copy link

blasut commented Jan 8, 2019

I've tested this for typescript and javascript and it works! I don't have go setup, but might be able to do that tomorrow

Justin Justin
Remove lsp-javascript-typescript package for lsp built in.
Remove lsp-go package for lsp built in.
Changed go/react/typescript lsp-*-enable hooks to lsp
Update go/typescript/rust layer docs for lsp-mode installation command.
Remove unused rust layer variable

@jamartin9 jamartin9 force-pushed the jamartin9:update-go-ts-react-lsp branch from 39027aa to b36aa6d Jan 10, 2019

@jamartin9 jamartin9 changed the title Fixes #11761 - update lsp go/ts/react Fixes #11761 - update lsp go/ts/react/rust Jan 10, 2019

@sdwolfz

This comment has been minimized.

Copy link
Collaborator

sdwolfz commented Jan 14, 2019

Thank you ❤️!
Cherry-picked into develop branch, you can safely delete your branch.
Commit: f8bb699

@sdwolfz sdwolfz closed this Jan 14, 2019

@jamartin9 jamartin9 deleted the jamartin9:update-go-ts-react-lsp branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment