New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates org-layer key bindings for Org 9.2 release #11804

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
4 participants
@samspills
Copy link

samspills commented Jan 6, 2019

Changes

This PR addresses my comment in issues #11788.

The new Org 9.2 release seems to have changed the functionality of org-set-tags, reserving it only for lisp calls, and added a new interactive function org-set-tags-command. The method of interacting with org easy-templates was also changed.

I updated the , i t binding to use org-set-tags-command, and I also added a new , i x binding for template expansion. (The old method of template expansion could be enabled with org-tempo, but I like the new style so I didn't look it into adding that to the layer).

@boothead

This comment has been minimized.

Copy link

boothead commented Jan 8, 2019

Nice one @samspills I just came to submit an issue for this :-)

@yuhan0

This comment has been minimized.

Copy link

yuhan0 commented Jan 8, 2019

Would i b (for insert block structure) be a better choice for the latter keybinding? i x seems rather arbitrary, unlike the old method there's no "expansion" taking place.

@sdwolfz sdwolfz added this to the Release 0.300 milestone Jan 8, 2019

@samspills

This comment has been minimized.

Copy link

samspills commented Jan 8, 2019

@yuhan0 i x doesn't feel arbitrary to me because I still think of it as template expansion, it's just that now I choose the template to expand through a menu instead of needing to remember the shortcut. That said I'm not attached to the binding and will switch if you (or anyone else) feels strongly!

@yuhan0

This comment has been minimized.

Copy link

yuhan0 commented Jan 9, 2019

No strong feelings on this either, perhaps one of the maintainers can decide? Just a comment that x generally stands for "text" elsewhere in Spacemacs, and I didn't realise that it meant "expand" here before reading your post.

@samspills

This comment has been minimized.

Copy link

samspills commented Jan 12, 2019

I didn't think about the confusion with x usually meaning text, that's a great point. I'll switch to the , i b binding :)

@samspills samspills force-pushed the samspills:sam/org-layer-bindings branch from 88eda7a to 29ff63a Jan 12, 2019

@samspills samspills force-pushed the samspills:sam/org-layer-bindings branch from 29ff63a to 03d36bb Jan 12, 2019

@sdwolfz

This comment has been minimized.

Copy link
Collaborator

sdwolfz commented Jan 14, 2019

Thank you ❤️!
And congratulations on your first Spacemacs PR 🎉!
Cherry-picked into develop branch, you can safely delete your branch.
Commit: 6d9dbcf

@sdwolfz sdwolfz closed this Jan 14, 2019

@samspills

This comment has been minimized.

Copy link

samspills commented Jan 14, 2019

Thanks :D

@samspills samspills deleted the samspills:sam/org-layer-bindings branch Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment